Make GatedReader
a test-only symbol, and allow all bevy_asset
tests to all run single threaded.
#18473
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
GatedReader
await for gates to open rather than blocking on it.async-channel
(already in tree). To avoid this additional dependency in most cases, I made this a dev-dependency.GatedReader
can only be used in tests (in bevy_asset). We could make this a feature flag, but it seems highly unlikely that real users need aGatedReader
- and if they need it for their test, they can just fork theGatedReader
.Testing
bevy_asset
tests pass without setting the--features multi_threaded
flag!Migration Guide
bevy_asset::io::gated::GatedReader
andbevy_asset::io::gated::GatedOpener
are no longer accessible to users.