Make GatedReader a test-only symbol, and allow all bevy_asset tests to all run single threaded.#18473
Merged
Merged
Conversation
c382019 to
154d50a
Compare
GatedReader a test-only symbol, and allow all tests to run single threaded.GatedReader a test-only symbol, and allow all bevy_asset tests to all run single threaded.
154d50a to
340c7f0
Compare
bushrat011899
approved these changes
Jul 2, 2025
Contributor
bushrat011899
left a comment
There was a problem hiding this comment.
Nice! async_channel is fully no_std anyway, so it's inclusion as a true dependency in the future wouldn't be an issue.
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
mockersf
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
GatedReaderawait for gates to open rather than blocking on it.async-channel(already in tree). To avoid this additional dependency in most cases, I made this a dev-dependency.GatedReadercan only be used in tests (in bevy_asset). We could make this a feature flag, but it seems highly unlikely that real users need aGatedReader- and if they need it for their test, they can just fork theGatedReader.Testing
bevy_assettests pass without setting the--features multi_threadedflag!Migration Guide
bevy_asset::io::gated::GatedReaderandbevy_asset::io::gated::GatedOpenerare no longer accessible to users.