Skip to content

Add builder method for TextFont::line_height #17203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Jan 6, 2025

Objective

Followup from #16614

TextFont has builder methods for its other fields. Add with_line_height for consistency.

Solution

Add it

@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Jan 7, 2025
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Text Rendering and layout for characters labels Jan 7, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 7, 2025
Merged via the queue into bevyengine:main with commit f896ad8 Jan 7, 2025
32 checks passed
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
# Objective

Followup from bevyengine#16614

`TextFont` has builder methods for its other fields. Add
`with_line_height` for consistency.

## Solution

Add it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Text Rendering and layout for characters C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants