Skip to content

Remove duplicated instruction line in lighting example #16767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

Remove duplicated instruction line in lighting example #16767

merged 1 commit into from
Dec 12, 2024

Conversation

rparrett
Copy link
Contributor

Objective

There are two of the same instruction in this example's instruction text.

Solution

Delete one

Testing

cargo run --example lighting

@rparrett rparrett added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 11, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 12, 2024
Merged via the queue into bevyengine:main with commit cca6a2b Dec 12, 2024
33 checks passed
Trashtalk217 pushed a commit to Trashtalk217/bevy that referenced this pull request Dec 21, 2024
@rparrett @Trashtalk217
Remove duplicated instruction line in lighting example (bevyengine#…
7cbac81 
…16767)

# Objective

There are two of the same instruction in this example's instruction
text.

## Solution

Delete one

## Testing

`cargo run --example lighting`
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@rparrett @ecoskey
Remove duplicated instruction line in lighting example (bevyengine#…
7efa3f5 
…16767)

# Objective

There are two of the same instruction in this example's instruction
text.

## Solution

Delete one

## Testing

`cargo run --example lighting`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcwalton pcwalton pcwalton approved these changes

@kristoff3r kristoff3r kristoff3r approved these changes

Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rparrett @pcwalton @kristoff3r @alice-i-cecile