Making sure each plugin indicates its default group and feature when …

[seivan]

Objective

• Updating plugin_group! macro to include the plugin's meta information.
• Making sure each plugin indicates its default group and feature when applicable.

Solution

• Output additional cfg flags when using plugin_group!
• For each plugin, add links to the plugin groups associated and necessary conditions.

Testing

• Checked that the docs updated accordingly.

---

[alice-i-cecile]

Neat idea, and I like the notes.

Two things:

• this macro really needs comments to explain how / why it works. I'm very surprised that we can modify docs for the plugin itself!
• the newly added lines should be below the manually added docs

[seivan]

• this macro really needs comments to explain how / why it works. I'm very surprised that we can modify docs for the plugin itself!

That makes two of us, I wasn't expecting it. Maybe you can ask the original developers to add those, I just modified it to include the custom directives from the cfg - in fact, I would have preferred it if we could extract the all(s), not(s) and target(s) to work the same way so they could be highlighted better with markdown instead of just blasted as a straight line. But imho, it's good enough for now and you don't have to check source.

• the newly added lines should be below the manually added docs

I'll change that.

You want to me remove the macro changes until someone can come along and explain/comment why it works?

[alice-i-cecile]

Leave the macro changes for now: I think they're an improvement :)

[alice-i-cecile]

@seivan Gentle reminder about this PR :) It's not far off merging now.

[mockersf]

I don't think the added doc on plugins should be the first line

the first line of docs is used by the html doc as a summary and presented alone in some context

[seivan]

@seivan Gentle reminder about this PR :) It's not far off merging now.

Sorry, was away. I’ll get on the changes requested tomorrow. 👌🏼

[seivan]

I don't think the added doc on plugins should be the first line

the first line of docs is used by the html doc as a summary and presented alone in some context

Yep @alice-i-cecile said as much, I will change it.