Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing registration for TextEntity #16649

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Add missing registration for TextEntity #16649

merged 1 commit into from
Dec 4, 2024

Conversation

coreh
Copy link
Contributor

@coreh coreh commented Dec 4, 2024 •
edited
Loading

Objective

Fix a Blenvy crash due to a missing type registration for TextEntity (as the type is used by ComputedTextBlock but wasn't itself registered.)

Solution

  • Added the missing type registration

Testing

  • N/A

@alice-i-cecile alice-i-cecile added this to the 0.15.1 milestone Dec 4, 2024
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Reflection Runtime information about types A-Text Rendering and layout for characters labels Dec 4, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 4, 2024
Merged via the queue into bevyengine:main with commit 7dfc77b Dec 4, 2024
33 checks passed
mockersf pushed a commit that referenced this pull request Jan 3, 2025
@coreh @mockersf
Add missing registration for TextEntity (#16649)
c520ec4 
# Objective

Fix a [Blenvy](https://github.com/kaosat-dev/Blenvy) crash due to a
missing type registration for `TextEntity` (as the type is used by
`ComputedTextBlock` but wasn't itself registered.)

## Solution

- Added the missing type registration

## Testing

- N/A
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@coreh @ecoskey
Add missing registration for TextEntity (bevyengine#16649)
1a3ae99 
# Objective

Fix a [Blenvy](https://github.com/kaosat-dev/Blenvy) crash due to a
missing type registration for `TextEntity` (as the type is used by
`ComputedTextBlock` but wasn't itself registered.)

## Solution

- Added the missing type registration

## Testing

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Reflection Runtime information about types A-Text Rendering and layout for characters C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.15.1
Development

Successfully merging this pull request may close these issues.
2 participants
@coreh @alice-i-cecile