Fix CAS toggle broken by retained render world #16533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristoff3r
added
C-Bug
Elabajaba
approved these changes
Nov 27, 2024
|
Would that work correctly if the |
No, that would break. But that can't happen with I think it just works if we run removals first, because in the "added then removed" case the query would be empty. |
alice-i-cecile
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Oh hey, this is a situation where @cart's "required components work on removal" would have solved that bug. Anyways, this is fine, merging.
mockersf
pushed a commit
that referenced
this pull request
Nov 28, 2024
# Objective Fixes #16531 I also added change detection when creating the pipeline, which technically isn't needed but it felt weird leaving it as is. ## Solution Remove the pipeline if CAS is disabled. The uniform was already being removed, which caused flickering / weirdness. ## Testing Tested the anti_alias example by toggling CAS a bunch on/off.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Dec 2, 2024
# Objective Fixes bevyengine#16531 I also added change detection when creating the pipeline, which technically isn't needed but it felt weird leaving it as is. ## Solution Remove the pipeline if CAS is disabled. The uniform was already being removed, which caused flickering / weirdness. ## Testing Tested the anti_alias example by toggling CAS a bunch on/off.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective Fixes bevyengine#16531 I also added change detection when creating the pipeline, which technically isn't needed but it felt weird leaving it as is. ## Solution Remove the pipeline if CAS is disabled. The uniform was already being removed, which caused flickering / weirdness. ## Testing Tested the anti_alias example by toggling CAS a bunch on/off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #16531
I also added change detection when creating the pipeline, which technically isn't needed but it felt weird leaving it as is.
Solution
Remove the pipeline if CAS is disabled. The uniform was already being removed, which caused flickering / weirdness.
Testing
Tested the anti_alias example by toggling CAS a bunch on/off.