Remove TransformCurve
#15598
Merged
Remove TransformCurve
#15598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweatherley
added
C-Usability
|
I'm open to being persuaded off of this, but I figured that if we should remove this, we have to do it soon, which is why I submitted this. :) |
alice-i-cecile
approved these changes
Oct 2, 2024
IQuick143
approved these changes
Oct 2, 2024
mweatherley
added
S-Ready-For-Final-Review
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Oct 4, 2024
# Objective It is somewhat unlikely we will actually be able to support `TransformCurve` (introduced in bevyengine#15434) after the `AnimationGraph` evaluation order changes in the immediate future. This is because correctly blending overlapping animation properties is nontrivial, and `Transform` overlaps with all of its own fields. We could still potentially create something like this in the future, but it's likely to require significant design and implementation work. By way of contrast, the single-property wrappers `TranslationCurve`, `ScaleCurve`, and `RotationCurve` should work perfectly fine, since they are non-overlapping. In this version release, creating `TransformCurve` in userspace is also quite easy if desired (see the deletions from this PR). ## Solution Delete `TransformCurve`. ## Migration Guide There is no released version that contains this, but we should make sure that `TransformCurve` is excluded from the release notes for bevyengine#15434 if we merge this pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
It is somewhat unlikely we will actually be able to support
TransformCurve(introduced in #15434) after theAnimationGraphevaluation order changes in the immediate future. This is because correctly blending overlapping animation properties is nontrivial, andTransformoverlaps with all of its own fields. We could still potentially create something like this in the future, but it's likely to require significant design and implementation work. By way of contrast, the single-property wrappersTranslationCurve,ScaleCurve, andRotationCurveshould work perfectly fine, since they are non-overlapping.In this version release, creating
TransformCurvein userspace is also quite easy if desired (see the deletions from this PR).Solution
Delete
TransformCurve.Migration Guide
There is no released version that contains this, but we should make sure that
TransformCurveis excluded from the release notes for #15434 if we merge this pull request.