-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export glTF skins as a Gltf struct #14343
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
I don't know that this is a problem per se, but I noticed that the error message "Unexpected child in GLTF Mesh" is from a older commit (removed in #13707). Which raises concern that this set of changes doesn't reflect more current work or there was a merge problem. (I'm not sure!) I only noticed because I was confused about "mesh" given the context. Maybe double check? |
It's true that some work in this part of the codebase may be omitted because I ported these changes from 0.12 to current main and. But I double checked and everything seems to be fine, the error about gltf mesh child is basically irrelevant anyways according to the pr that removed it ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a reasonable step forward :) Thanks for putting in the work to get this together.
Objective
Solution
GltfSkin
, representing skin data from a glTF file, new memberskin
toGltfNode
and bothskins
+named_skins
toGltf
(a la meshes/nodes).GltfNodes
with their associatedGltfSkin
while iterating, their dependencies already have been loaded.GltfSkin
andSkinnedMeshInverseBindposes
in assets: prior to this PR,GltfAssetLabel::Skin(n)
was responsible not for a skin, but for one of skin's components. NowGltfAssetLabel::InverseBindMatrices(n)
will map toSkinnedMeshInverseBindposes
, andGltfAssetLabel::Skin(n)
will map toGltfSkin
.Testing
skin_node
does just that; it tests whether or notGltfSkin
was loaded properly.Migration Guide
GltfAssetLabel::Skin(..)
toGltfAssetLabel::InverseBindMatrices(..)
.