Refactor build-templated-pages/features #12241
Conversation
|
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
alice-i-cecile
changed the title
alice-i-cecile
changed the title
alice-i-cecile
added
C-Code-Quality
| let value = |v: &Value| { | ||
| let feature_name = v.as_str().unwrap(); | ||
| let feature = |v: &Value| v.as_str().unwrap().to_string(); | ||
| let features_to_array = |name| features.get(name).unwrap().as_array().unwrap(); | ||
| let map = features_to_array(feature_name).iter().map(feature); | ||
| std::iter::once(feature_name.to_string()).chain(map) | ||
| }; |
There was a problem hiding this comment.
This is quite difficult to read. Is there a way to refactor this so it is more understandable? (Even better, if you can return impl Iterator<Item = String / &str>.)
If that's not possible, could you add comments explaining the purpose of this code?
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
|
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
|
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
|
You added a new feature but didn't add a description for it. Please update the root Cargo.toml file. |
IQuick143
added
the
S-Adopt-Me
Objective
Solution