Re-export smallvec crate from bevy_utils #11006
Conversation
Matches versioning & features from other Cargo.toml files in the project.
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
|
For the crates that rely on bevy_utils already, we should use this re-export instead. |
alice-i-cecile
added
C-Code-Quality
|
Got a little tripped up with bevy_reflect's smallvec compiler feature, but I think I've got it now. All bevy sub-crates that used smallvec were also using bevy_utils, so I was able to get them all moved over. If we'd like to upgrade from 1.6 to 1.11, this should make it easier. |
|
Yep, feel free to upgrade in this PR. |
|
This should be ready for review btw |
|
smallvec 1.11 was already used, as it's semver compatible with 1.6. Putting it explicitly means it won't compile anymore for someone that for whatever reason can't update to the 1.11. This case probably doesn't matter, but it was the reason why it was still on 1.6 |
james7132
added
the
S-Ready-For-Final-Review
Matches versioning & features from other Cargo.toml files in the project.
Objective
Resolves #10932
Solution
Added smallvec to the bevy_utils cargo.toml and added a line to re-export the crate. Target version and features set to match what's used in the other bevy crates.