Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug the visualization of the drivable area. #6527

Conversation

YoshihiroMichishita-PT
Copy link

Description

Related ticket: https://tier4.atlassian.net/browse/RT1-5061

The current postProcess in static_drivable_area.cpp does not work when backing (is_driving_forward=false), and that results in as follows:
drivable_area_old_when_backing

To resolve this problem, I have changed three points:

  1. Delete the reverse process because this process does not match the later processes. (L1504-L1506 in the current static_drivable_area.cpp)
  2. Choose goal_idx as the more far point from start_idx and add the medium point between start_idx and goal_idx even when start_idx > goal_idx in order to work properly when is_driving_forward=false . (L1530~ in the current static_drivable_area.cpp)
  3. Perform an emergent measure on a bad visualization in a certain situation, by normalizing adaptive_width . (L84 in display.hpp)

Test performed

I have compared the visualization of the drivable area after applying the above changes to the original one , which is shown in the JIRA ticket:https://tier4.atlassian.net/browse/RT1-5061

Effect on the visualization of the drivable area.

When just backing, it works well. When backing after driving forward, it sometimes shows a short drivable area. (So the bug may still remains)

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
    After all checkboxes are checked, anyone who has write access can merge the PR.

tier4-autoware-public-bot bot and others added 7 commits February 7, 2024 09:32
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
chore: sync beta branch beta/v0.22.0 with tier4/main
chore: sync tier4/autoware.universe:awf-latest
chore: sync beta branch beta/v0.23.0 with tier4/main
normalize adaptive width
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Mar 1, 2024
@shmpwk shmpwk self-assigned this Mar 1, 2024
Copy link

stale bot commented May 1, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 1, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Dec 10, 2024

@shmpwk could you look into this PR?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 10, 2024
@shmpwk
Copy link
Contributor

shmpwk commented Dec 12, 2024

I close this PR since this PR was re-organized in #7182 🙏

@shmpwk shmpwk closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.