-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug the visualization of the drivable area. #6527
Closed
YoshihiroMichishita-PT
wants to merge
433
commits into
autowarefoundation:main
from
YoshihiroMichishita-PT:tier4/main
Closed
Debug the visualization of the drivable area. #6527
YoshihiroMichishita-PT
wants to merge
433
commits into
autowarefoundation:main
from
YoshihiroMichishita-PT:tier4/main
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
chore: sync upstream
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
chore: sync beta branch beta/v0.22.0 with tier4/main
chore: sync tier4/autoware.universe:awf-latest
chore: sync beta branch beta/v0.23.0 with tier4/main
normalize adaptive width
This pull request has been automatically marked as stale because it has not had recent activity. |
4 tasks
@shmpwk could you look into this PR? |
I close this PR since this PR was re-organized in #7182 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related ticket: https://tier4.atlassian.net/browse/RT1-5061
The current postProcess in static_drivable_area.cpp does not work when backing (is_driving_forward=false), and that results in as follows:

To resolve this problem, I have changed three points:
reverse
process because this process does not match the later processes. (L1504-L1506 in the currentstatic_drivable_area.cpp
)goal_idx
as the more far point fromstart_idx
and add the medium point betweenstart_idx
andgoal_idx
even whenstart_idx > goal_idx
in order to work properly whenis_driving_forward=false
. (L1530~ in the currentstatic_drivable_area.cpp
)adaptive_width
. (L84 indisplay.hpp
)Test performed
I have compared the visualization of the drivable area after applying the above changes to the original one , which is shown in the JIRA ticket:https://tier4.atlassian.net/browse/RT1-5061
Effect on the visualization of the drivable area.
When just backing, it works well. When backing after driving forward, it sometimes shows a short drivable area. (So the bug may still remains)
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.