Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner_common): drivable are bug #7182

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented May 31, 2024

Description

Refactor of #6527.

Before:
Screenshot from 2024-02-29 16-30-46

After:
Screenshot from 2024-02-29 16-49-40

The details are as follows: https://tier4.atlassian.net/browse/RT1-5061

Tests performed

No scenario degration: 3106/3107

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels May 31, 2024
@shmpwk shmpwk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 31, 2024
@shmpwk shmpwk marked this pull request as ready for review May 31, 2024 12:26
shmpwk and others added 4 commits May 31, 2024 21:34
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
@shmpwk shmpwk force-pushed the fix/drivable-are branch from 8e4a8c8 to d77c48b Compare May 31, 2024 12:34
Copy link

github-actions bot commented Jul 27, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@shmpwk shmpwk marked this pull request as draft July 27, 2024 07:23
Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 24.14%. Comparing base (3e4a945) to head (4cf5a3b).
Report is 428 commits behind head on main.

Files with missing lines Patch % Lines
...nclude/tier4_planning_rviz_plugin/path/display.hpp 0.00% 3 Missing ⚠️
...ware_behavior_path_planner/src/planner_manager.cpp 50.00% 1 Missing ⚠️
...s/drivable_area_expansion/static_drivable_area.cpp 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7182      +/-   ##
==========================================
- Coverage   24.16%   24.14%   -0.03%     
==========================================
  Files        1401     1407       +6     
  Lines      102254   103237     +983     
  Branches    38750    38752       +2     
==========================================
+ Hits        24707    24922     +215     
- Misses      74972    75741     +769     
+ Partials     2575     2574       -1     
Flag Coverage Δ *Carryforward flag
differential 15.02% <58.33%> (?)
total 24.16% <ø> (-0.01%) ⬇️ Carriedforward from 3e4a945

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shmpwk shmpwk marked this pull request as ready for review September 2, 2024 03:54
Copy link

stale bot commented Nov 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 4, 2024
@mitsudome-r
Copy link
Member

@shmpwk This has been stale for a long time. Could you check if you still need this PR?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants