-
Notifications
You must be signed in to change notification settings - Fork 201
Comparing changes
Open a pull request
base repository: adobe/spectrum-css
base: @spectrum-css/preview@5.0.4
head repository: adobe/spectrum-css
compare: @spectrum-css/preview@5.0.5
- 16 commits
- 239 files changed
- 13 contributors
Commits on Sep 27, 2023
-
chore: add vscode recommendations; jira commit tagging (#1854)
* chore: add vscode recommendations; jira commit tagging * chore: revert prepare-commit-msg addition
Configuration menu - View commit details
-
Copy full SHA for a0ff750 - Browse repository at this point
Copy the full SHA a0ff750View commit details
Commits on Oct 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7e9695d - Browse repository at this point
Copy the full SHA 7e9695dView commit details -
feat(overlay)!: migrate to spectrum-tokens (#2165)
BREAKING CHANGE: migrates Overlay to use `@adobe/spectrum-tokens` * feat(overlay): migrate to use spectrum-tokens BREAKING CHANGE: migrate overlay to use spectrum tokens * chore(tokens): add custom tokens to overlay component * docs: regenerate mods --------- Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com> Co-authored-by: Patrick Fulton <pfulton@adobe.com>
Configuration menu - View commit details
-
Copy full SHA for 0331dae - Browse repository at this point
Copy the full SHA 0331daeView commit details -
feat(modal)!: diy migration (#2164)
BREAKING CHANGE: migrates Modal to use `@adobe/spectrum-tokens` Additionally: * feat(modal)!: migrate to spectrum tokens * chore(tokens): add modal custom tokens chore(modal): fixed indentation index.css chore(modal): added mod variables chore(modal): updated package version chore(modal): updated css to use custom tokens for animation chore: updated css properties * docs(modal): regenerate mods --------- Co-authored-by: Patrick Fulton <pfulton@adobe.com>
Configuration menu - View commit details
-
Copy full SHA for 0b83f13 - Browse repository at this point
Copy the full SHA 0b83f13View commit details
Commits on Oct 13, 2023
-
feat(dialog)!: migrate to spectrum-tokens (#2168)
BREAKING CHANGE: migrates to use `@adobe/spectrum-tokens` Additionally: * feat(dialog): migrate to use spectrum-tokens BREAKING CHANGE: migrate dialog to use spectrum tokens * docs(dialog): regenerate mods file --------- Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com> Co-authored-by: Patrick Fulton <pfulton@adobe.com>
Configuration menu - View commit details
-
Copy full SHA for 0811386 - Browse repository at this point
Copy the full SHA 0811386View commit details -
feat(millercolumns)!: migrate to spectrum-tokens (#2191)
BREAKING CHANGE: migrates MillerColumns to use `@adobe/spectrum-tokens` Additionally: * chore(miller): update build * chore(miller): use new tokens * chore(miller): remove extra space * fix(miller): storybook only files selectable * chore(millercolumns): rename custom properties * docs(miller): generate mods --------- Co-authored-by: Patrick Fulton <pfulton@adobe.com>
Configuration menu - View commit details
-
Copy full SHA for aa163d2 - Browse repository at this point
Copy the full SHA aa163d2View commit details -
feat(logicbutton)!: migrate to use spectrum-tokens (#2175)
BREAKING CHANGE: migrates to use `@adobe/spectrum-tokens` Additionally: * chore(logicbutton): update to use tokens * feat(logicbutton): working on converting css to tokens * feat(logicbutton): utilize core tokens * chore(logicbutton): add spectrum and express files, fix unclosed css block * fix(logicbutton): fix and colors * chore(logicbutton): add additional stories for or and disabled * style(logicbutton): update WHCM styling for disabled button * docs(logicbutton): add spacing for examples Adds some extra room between the example buttons in the docs site. Refs #714 CSS-218 * fix(logicbutton): add type of button to doc examples * chore(logicbutton): update button import, remove vars imports * fix(logicbutton): disabled buttons dont have a hover state in high contrast mode --------- Co-authored-by: Patrick Fulton <pfulton@adobe.com> Co-authored-by: Melissa Thompson <mthompson@heysparkbox.com>
Configuration menu - View commit details
-
Copy full SHA for f4dc972 - Browse repository at this point
Copy the full SHA f4dc972View commit details -
feat(pagination)!: migrate to spectrum tokens package
BREAKING CHANGE: Replaces DNA tokens with Spectrum tokens. Update build to use Spectrum tokens. Remove skin.css and incorporate its CSS into index.css. refactor(pagination): styles migration to core tokens Migration of stylesheet to use Spectrum tokens. refactor(pagination): remove unused pagebutton class Remove CSS for .spectrum-Pagination-pageButton which is not used anywhere in the repo. This removes the need for additions to the custom tokens. fix(pagination): correct direction of arrows for right-to-left When viewing in RTL, the arrows were both facing in the same direction. This was because they were both setting the same rotation, and one of the arrows icons already uses a 180 degree rotation. fix: counter text sizing and t-shirt sizing docs Disable t-shirt size in Storybook until it is fully supported. To be supported it will need font sizes for the counter text and probably changes to the inline margins. For the counter text, removes spectrum-Body--secondary which doesn't seem to exist anymore, and applies the appropriate font size (14px at medium) and line-height tokens. docs(pagination): add button style pagination to storybook Add the "Button style" version of Pagination from the docs to Storybook.
Configuration menu - View commit details
-
Copy full SHA for f29a74d - Browse repository at this point
Copy the full SHA f29a74dView commit details -
docs: additional splitbutton and button storybook options
Some additional args were needed for SplitButton to support the "Button style" example for Pagination, allowing another icon next to the SplitButton label. And Button allowing the icon to appear after the label text. SplitButton also had a disabled arg control with the "cta" option that was actually "accent".
Configuration menu - View commit details
-
Copy full SHA for fce04d3 - Browse repository at this point
Copy the full SHA fce04d3View commit details -
feat(dial)!: migrate to use
@adobe/spectrum-tokens
(#1971)BREAKING CHANGE: migrates the Dial component to `@adobe/spectrum-tokens` Additionally: * chore(dial): begin migrating from old to new tokens * chore(dial): use latest dependencies * feat(dial): replace vars with new values * chore(dial): update to latest deps * chore(dial): update dependencies * chore(dial): finish migration Uses correct colors & removes duplicate properties * chore(dial): high-contrast fixes * chore(dial): rename custom properties * refactor(dial): focus and dragged states and SB controls * chore(dial): address left margin issue * chore(dial): address PR feedback * chore(dial): address PR feedback for disabled state * refactor(dial): use focus-visible * chore(dial): remove disabled from tab order * chore(dial): adds focus-visible --------- Co-authored-by: Jenn Diaz <jenn.diaz@heysparkbox.com>
Configuration menu - View commit details
-
Copy full SHA for f116b7e - Browse repository at this point
Copy the full SHA f116b7eView commit details -
refactor(dialog): remove unused custom properties (#2212)
* removes two unused custom properties: `--spectrum-dialog-confirm-max-inline-size` `--spectrum-dialog-confirm-max-height` Those have been in the repo for quite some time, but have never been used in Spectrum CSS itself.
Configuration menu - View commit details
-
Copy full SHA for f60c5ff - Browse repository at this point
Copy the full SHA f60c5ffView commit details -
refactor(fieldlabel): spectrum-Form cleanup and fixes (#2173)
* refactor(fieldlabel): spectrum-Form cleanup and fixes - Fixes missing spacing between form items in Labels Above variant. This was using the wrong token (top-to-asterisk) - Removes --spectrum-field-label-top-to-asterisk as it is no longer used - Cleans up the CSS and its custom properties a bit - Removed two comments that were no longer applicable. One mentioned a docs file that does not seem to exist anymore, and the other mentioned a token value of 20px but it doesn't equal 20px. - Fixes form negative margin being too large and it moving outside its container. Instead use same value as border-spacing to remove the extra space, to make this like a margin top and bottom of zero which seems like the original intention. * docs(picker): define type of button on button elements Buttons will default to a type of "submit" within a form, resulting in unexpected form submission on click, which was happening in the examples. Sets type="button" on usage of button element used for the picker in the docs. * docs(fieldlabel): form - add stories Add stories for the "Form" component that exists as its own entry in the docs (the CSS actually exists within the fieldlabel component). * docs(fieldlabel): fix some example docs for form - Fix incorrect field group usage in example markup for Form. Previously had a "for" attribute for an ID that didn't exist, and was using a label. But this was more of a fieldset usage and needed to use the aria attributes (reference Field group). - Improves some titles and descriptions to be more clear about alignment
Configuration menu - View commit details
-
Copy full SHA for 9c4a620 - Browse repository at this point
Copy the full SHA 9c4a620View commit details -
fix(menu): drill-in disabled menu item chevron (#2199)
A drill-in set to "open" was no longer showing the disabled color for the chevron icon. Moves disabled CSS after other CSS, which resolves this issue. Also includes this in the existing Storybook example for drill-in. Fixes #2176
Configuration menu - View commit details
-
Copy full SHA for 2dba5d9 - Browse repository at this point
Copy the full SHA 2dba5d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 396bca9 - Browse repository at this point
Copy the full SHA 396bca9View commit details -
Configuration menu - View commit details
-
Copy full SHA for eba991c - Browse repository at this point
Copy the full SHA eba991cView commit details -
- @spectrum-css/accordion@4.0.22 - @spectrum-css/actionbar@7.0.6 - @spectrum-css/actionbutton@5.0.12 - @spectrum-css/actiongroup@4.1.4 - @spectrum-css/actionmenu@5.0.5 - @spectrum-css/alertbanner@1.1.30 - @spectrum-css/alertdialog@1.0.11 - @spectrum-css/assetcard@2.0.13 - @spectrum-css/assetlist@4.0.0 - @spectrum-css/avatar@6.0.57 - @spectrum-css/badge@3.1.13 - @spectrum-css/breadcrumb@8.0.12 - @spectrum-css/button@11.0.13 - @spectrum-css/buttongroup@6.1.11 - @spectrum-css/calendar@4.0.17 - @spectrum-css/card@6.0.23 - @spectrum-css/checkbox@7.0.16 - @spectrum-css/clearbutton@5.0.10 - @spectrum-css/closebutton@4.0.12 - @spectrum-css/coachmark@5.0.72 - @spectrum-css/colorarea@4.0.46 - @spectrum-css/colorhandle@7.0.12 - @spectrum-css/colorloupe@4.1.23 - @spectrum-css/colorslider@5.0.9 - @spectrum-css/colorwheel@3.0.46 - @spectrum-css/combobox@2.0.42 - @spectrum-css/commons@9.0.0 - @spectrum-css/contextualhelp@2.0.40 - @spectrum-css/cyclebutton@3.0.86 - @spectrum-css/datepicker@1.0.55 - @spectrum-css/dial@2.0.0 - @spectrum-css/dialog@9.0.0 - @spectrum-css/divider@2.1.30 - @spectrum-css/dropzone@5.0.26 - @spectrum-css/fieldgroup@4.0.77 - @spectrum-css/fieldlabel@7.1.2 - @spectrum-css/floatingactionbutton@1.0.32 - @spectrum-css/helptext@4.0.59 - @spectrum-css/illustratedmessage@6.0.26 - @spectrum-css/infieldbutton@4.0.1 - @spectrum-css/inlinealert@7.0.51 - @spectrum-css/link@4.0.70 - @spectrum-css/logicbutton@3.0.0 - @spectrum-css/menu@5.1.2 - @spectrum-css/miller@4.0.0 - @spectrum-css/modal@4.0.0 - @spectrum-css/overlay@4.0.0 - @spectrum-css/page@6.0.5 - @spectrum-css/pagination@7.0.0 - @spectrum-css/picker@7.0.13 - @spectrum-css/pickerbutton@4.0.17 - @spectrum-css/popover@6.0.79 - @spectrum-css/progressbar@3.0.76 - @spectrum-css/progresscircle@2.0.70 - @spectrum-css/quickaction@3.0.88 - @spectrum-css/radio@8.0.13 - @spectrum-css/rating@4.0.30 - @spectrum-css/search@6.0.25 - @spectrum-css/searchwithin@5.0.19 - @spectrum-css/sidenav@4.0.14 - @spectrum-css/slider@4.1.14 - @spectrum-css/splitbutton@6.0.13 - @spectrum-css/splitview@4.0.5 - @spectrum-css/statuslight@6.0.57 - @spectrum-css/steplist@4.0.4 - @spectrum-css/stepper@5.0.1 - @spectrum-css/swatch@5.0.17 - @spectrum-css/swatchgroup@2.0.73 - @spectrum-css/switch@4.0.12 - @spectrum-css/table@5.0.6 - @spectrum-css/tabs@4.0.22 - @spectrum-css/tag@8.0.11 - @spectrum-css/taggroup@4.0.9 - @spectrum-css/textfield@6.0.25 - @spectrum-css/thumbnail@5.0.12 - @spectrum-css/toast@9.1.14 - @spectrum-css/tokens@12.0.0 - @spectrum-css/tooltip@5.1.16 - @spectrum-css/tray@2.1.17 - @spectrum-css/treeview@9.0.3 - @spectrum-css/typography@5.0.45 - @spectrum-css/underlay@3.0.8 - @spectrum-css/well@4.0.5 - @spectrum-css/preview@5.0.5
Configuration menu - View commit details
-
Copy full SHA for db5d42e - Browse repository at this point
Copy the full SHA db5d42eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff @spectrum-css/preview@5.0.4...@spectrum-css/preview@5.0.5