feat(logicbutton): update to use tokens #2175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlogsdon18
force-pushed
the
css-578-logic-button
branch
from
912edcf to
dbd9959
Compare
|
🚀 Deployed on https://pr-2175--spectrum-css.netlify.app |
mlogsdon18
force-pushed
the
css-578-logic-button
branch
from
dbd9959 to
5986213
Compare
jawinn
suggested changes
Sep 20, 2023
There was a problem hiding this comment.
There is one update needed for high contrast mode. On the disabled buttons, the border is currently changing to the highlight color on hover, making it look interactive. It should remain as the GrayText.
While we're there, it'd be a good idea to add the type="button" attribute to all of the <button> elements used within the example docs and the storybook template.
pfulton
force-pushed
the
css-578-logic-button
branch
from
3d770f2 to
a0a2513
Compare
mdt2
force-pushed
the
css-578-logic-button
branch
from
eda2352 to
2f6581b
Compare
jawinn
approved these changes
Sep 26, 2023
pfulton
force-pushed
the
css-578-logic-button
branch
from
2f6581b to
15988fa
Compare
mdt2
pushed a commit
that referenced
this pull request
Oct 11, 2023
mdt2
pushed a commit
that referenced
this pull request
Oct 11, 2023
12 tasks
Adds some extra room between the example buttons in the docs site. Refs #714 CSS-218
jawinn
force-pushed
the
css-578-logic-button
branch
from
15988fa to
3dd6471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Logic Button component to utilize Spectrum tokens. It also adds two additional stories to Storybook to test the Or variant and Disabled.
How and where has this been tested?
Tested by @jawinn :
Regression testing
Validate: @jawinn
Screenshots
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨