Skip to content

docs(splitbutton): fix spectrum link #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

csantos1113
Copy link
Contributor

@csantos1113 csantos1113 commented Sep 21, 2023

Description

Update spectrum link because the one introduced in #2134 seems to be failing and it isn't the official public documentation anyway

image

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Open the Docs Site for the Split Button component:

  • Ensure you can see updated Usage Notes

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@pfulton pfulton self-requested a review September 27, 2023 19:30
@pfulton
Copy link
Collaborator

pfulton commented Sep 27, 2023

Thanks for catching this, @csantos1113! The original URL does work, but only for Adobe employees, as it's behind a firewall. So, we probably never noticed that it wasn't accessible for non-Adobe folks.

@csantos1113
Copy link
Contributor Author

Thanks for catching this, @csantos1113! The original URL does work, but only for Adobe employees, as it's behind a firewall. So, we probably never noticed that it wasn't accessible for non-Adobe folks.

Thanks for the approval. I wonder if there are more links that need to be updated

Update spectrum link
@pfulton pfulton merged commit 396bca9 into adobe:main Oct 13, 2023
@csantos1113 csantos1113 deleted the patch-1 branch October 13, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants