-
Notifications
You must be signed in to change notification settings - Fork 201
refactor(millercolumns)!: tokens migration #2191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Deployed on https://pr-2191--spectrum-css.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! The only two things I saw were what you already found that are related to AssetList and not this component (dark themes appearance and indicating keyboard focus).
components/miller/index.css
Outdated
--spectrum-millercolumn-margin-left: var(--spectrum-spacing-100); | ||
--spectrum-millercolumn-margin-right: var(--spectrum-spacing-100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two could be renamed with logical property naming? e.g. --spectrum-millercolumn-margin-inline-start
4eea1da
to
c719a8e
Compare
Description
Migrates the MillerColumn component
Also:
Jira Ticket 509
Does not address issues within the asset list, added comment to Jira ticket for the Asset List migration detailing issues.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Tested by @jawinn
Test Outline
Regression testing
Validate:
Screenshots
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨