Skip to content

chore(tokens): batch add component-specific diy migration tokens #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

mdt2
Copy link
Collaborator

@mdt2 mdt2 commented Oct 11, 2023

Description

Batch adding component-specific custom tokens from PRs #2164, #2168, #2185, #2175, #2188, and #1971 (all custom tokens that are ready for merge according to our merge queue doc).

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Regression testing

Validate:

  1. A legacy documentation page (such as accordion), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive
  1. A migrated documentation page (such as action group), including:
  • The page renders correctly
  • The page is accessible
  • The page is responsive

To-do list

  • I have read the contribution guidelines.

  • I have updated relevant storybook stories and templates.

  • I have tested these changes in Windows High Contrast mode.

  • If my change impacts other components, I have tested to make sure they don't break.

  • If my change impacts documentation, I have updated the documentation accordingly.

  • ✨ This pull request is ready to merge. ✨

Batch adding component-specific custom tokens from PRs #2164, #2168, #2185, #2175, #2188, and #1971
@mdt2 mdt2 changed the title chore: batch of diy migration tokens chore(tokens): batch add component-specific diy migration tokens Oct 11, 2023
@github-actions
Copy link
Contributor

🚀 Deployed on https://pr-2208--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 11, 2023 15:21 Inactive
@mdt2 mdt2 requested review from jawinn, jenndiaz and pfulton October 11, 2023 15:29
Copy link
Collaborator

@pfulton pfulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pfulton pfulton merged commit 7e9695d into main Oct 12, 2023
@pfulton pfulton deleted the mdt2/batch-tokens branch October 12, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants