chore(dialog): diy migration

[blunteshwar]

Description

Migrated dialog ro core tokens

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Regression testing

Validate:

1. A legacy documentation page (such as accordion), including:

• The page renders correctly
• The page is accessible
• The page is responsive

2. A migrated documentation page (such as action group), including:

• The page renders correctly
• The page is accessible
• The page is responsive

Screenshots

To-do list

• I have read the contribution guidelines.

• I have updated relevant storybook stories and templates.

• I have tested these changes in Windows High Contrast mode.

• If my change impacts other components, I have tested to make sure they don't break.

• If my change impacts documentation, I have updated the documentation accordingly.

• ✨ This pull request is ready to merge. ✨

[github-actions]

🚀 Deployed on https://pr-2168--spectrum-css.netlify.app

[mlogsdon18]

Just a few things. Overall great job!

[mdt2]

I'm seeing some visual differences (color and spacing) between this migration and the component on production, can you take a look if you see the same?

[blunteshwar]

I'm seeing some visual differences (color and spacing) between this migration and the component on production, can you take a look if you see the same?

Solved!

[mdt2]

It's looking really good! Just a couple Express theme questions.

The border-radius looks different with the Express theme as well:

[blunteshwar]

It's looking really good! Just a couple Express theme questions.

The border-radius looks different with the Express theme as well:

Resolved!

[mdt2]

This looks good to me!

[jawinn]

I just looked over the changed files and noticed mostly some formatting adjustments, along with a couple custom properties that I think should be renamed.

[jawinn]

I went through the previous comments and marked some as resolved. It looks like a few still need updates. Another thing I noticed below, which is similar to the other comments about custom property names.

[blunteshwar]

Thanks for those updates. Other than the requested changes below, can you also took at these previous comments about the formatting of the fallback vars throughout the index.css file? I'm looking at changed files and most of them still need spaces.

Done!

[jawinn]

Thanks for those updates. Other than the requested changes below, can you also took at these previous comments about the formatting of the fallback vars throughout the index.css file? I'm looking at changed files and most of them still need spaces.

Done!

Thanks. It looks like a few have double spaces now. Once that's fixed and the mods.md file is regenerated, this should be ready for approval.

[blunteshwar]

Thanks for those updates. Other than the requested changes below, can you also took at these previous comments about the formatting of the fallback vars throughout the index.css file? I'm looking at changed files and most of them still need spaces.

Done!

Thanks. It looks like a few have double spaces now. Once that's fixed and the mods.md file is regenerated, this should be ready for approval.

Done!