feat(modal): diy migration #2164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2164--spectrum-css.netlify.app |
mlogsdon18
suggested changes
Sep 13, 2023
pfulton
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Just a few things to fix up here, @TarunAdobe. We have some tokens for animations that we defined here: https://github.com/adobe/spectrum-css/blob/a0ff7502807b1b6e464a330574fa909024a18bf6/components/tokens/custom-spectrum/custom-vars.css#L20C3-L37 - that's where I pulled my suggestions from.
pfulton
requested review from
jawinn and
jenndiaz
and removed request for
mlogsdon18
jawinn
approved these changes
Sep 29, 2023
TarunAdobe
force-pushed
the
tarun/modal-diy-migration
branch
2 times, most recently
from
b61194d to
f68fc20
Compare
mdt2
pushed a commit
that referenced
this pull request
Oct 11, 2023
mdt2
pushed a commit
that referenced
this pull request
Oct 11, 2023
12 tasks
chore(modal): fixed indentation index.css chore(modal): added mod variables chore(modal): updated package version chore(modal): updated css to use custom tokens for animation chore: updated css properties
pfulton
force-pushed
the
tarun/modal-diy-migration
branch
from
f68fc20 to
54377c3
Compare
pfulton
approved these changes
Oct 12, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrating modal component to diy core tokens.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Regression testing
Validate:
Screenshots
To-do list
I have read the contribution guidelines.
I have updated relevant storybook stories and templates.
I have tested these changes in Windows High Contrast mode.
If my change impacts other components, I have tested to make sure they don't break.
If my change impacts documentation, I have updated the documentation accordingly.
✨ This pull request is ready to merge. ✨