Skip to content

[Core] Fix XR support in CoreUtils.Drawfullscreen #6287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2021
Merged

[Core] Fix XR support in CoreUtils.Drawfullscreen #6287

merged 3 commits into from
Nov 25, 2021

Conversation

alelievr
Copy link
Member

Purpose of this PR

Fix XR support in CoreUtils.Drawfullscreen (missing depth slice parameter in cmd.SetRenderTarget)

Testing status

Tested inside HDRP with a custom pass using this code to render a fullscreen quad:

        CoreUtils.DrawFullScreen(ctx.cmd, material, ctx.cameraColorBuffer);

Before:
image

After:
image

@alelievr alelievr added the HDRP label Nov 15, 2021
@alelievr alelievr self-assigned this Nov 15, 2021
@alelievr alelievr marked this pull request as ready for review November 15, 2021 16:28
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@github-actions github-actions bot added the SRP label Nov 15, 2021
RemyUnity
RemyUnity approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@RemyUnity RemyUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sebastienlagarde sebastienlagarde merged commit d4848bd into master Nov 25, 2021
@sebastienlagarde sebastienlagarde deleted the core/fix/vr-support-drawfullscreen branch November 25, 2021 13:56
sebastienlagarde added a commit that referenced this pull request Nov 28, 2021
@alelievr @sebastienlagarde
[Core] Fix XR support in CoreUtils.Drawfullscreen (#6287)
fec028b 
* Fix XR support in CoreUtils.DrawFullscreen function

* Updated changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
@sebastienlagarde sebastienlagarde mentioned this pull request Nov 29, 2021
Merged
sebastienlagarde added a commit that referenced this pull request Nov 29, 2021
@sebastienlagarde @alelievr @JulienIgnace-Unity
[HDRP] Backport miss set of PRs (#6414)
0c42a20 
* [Core] Fix XR support in CoreUtils.Drawfullscreen (#6287)

* Fix XR support in CoreUtils.DrawFullscreen function

* Updated changelog

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Physically Based Sky documentation now mentions the warmup cost explicitly (#6323)

* Physically Based Sky documentation now mentions the warmup cost explicitly.

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [HDRP] Merge HD/bugfix #6387

* Update CHANGELOG.md

* fix compilation issue

* Fix compil issue bis

* Update PostProcessSystem.cs

* Fix compil issue - bis bis

* Update PostProcessSystem.RenderGraph.cs

* Revert: [HDRP] Fix rasterized accumulation motion blur when DoF is enabled #6380

* Revert Fixed broken rendering when duplicating a camera while the Rendering Debugger is opened. #6289

Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
sebastienlagarde pushed a commit that referenced this pull request Dec 8, 2021
@alelievr @sebastienlagarde
[Core] Fix XR support in CoreUtils.Drawfullscreen #6287
0129228
@sebastienlagarde sebastienlagarde mentioned this pull request Dec 8, 2021
Merged
sebastienlagarde added a commit that referenced this pull request Dec 9, 2021
@sebastienlagarde @anisunity
@adrien-de-tocqueville @alelievr @kecho @skhiat @JulienIgnace-Unity @Vic-Cooper @arttu-peltonen @eturquin
[HDRP] Backport various Fix Prs (#6535)
7f058f1 
* - Fixed edges and ghosting appearing on shadow matte due to the shadow being black outside the range of the light (case 1371441). #6279

* Fixed interpolation issue with wind orientation (case 1379841). #6284

* Fixed range fields for depth of field #6285

* [Core] Fix XR support in CoreUtils.Drawfullscreen #6287

* ** Fixing DLSS failing when MV are disabled ** (#6292)

* Using texture types instead of RenderTexture types for DLSSPass

* Changelog

* Formatting

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* [Fix] Lens Flare visible when being behind a camera with Panini Projection on (case 1370214) (#6293)

* Fix panini for LensFlare

* Add changelog

* Update CHANGELOG.md

* Fixed the ray tracing acceleration structure build marker not being included in the ray tracing stats (case 1379383). #6277

* [HDRP] Remove alpha from local volumetric fog color field #6310

* [HDRP] Changed default numbder of physically based sky bounce from 8 to 3 #6304

* [HDRP] Improve decal performances when they use different material and the same draw order. #6303

* [HDRP] Update reference screenshots #6404

* Fixed Nans happening due to volumetric clouds when the pixel color is perfectly black (case 1379185). #6311

* Fixed missing information in the tooltip of affects smooth surfaces of the ray traced reflections denoiser (case 1376918). #6321

* Physically Based Sky documentation now mentions the warmup cost explicitly (#6323)

* Physically Based Sky documentation now mentions the warmup cost explicitly.

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>

* Reviewed PR #6031 (#6340)

* Reviewed PR #6031

Also generally improved this doc, fixed typos and added screenshots.

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>

* Fix preview scene objects marked dirty by migration #6361

* [HDRP][Path Tracing] Fixed PS5 build compilation warnings #6362

* Fix compil issue

* Apply formatting changes

* Update VisualEnvironment.cs

* Fix HDRP warning (#6396)

* [HDRP][Metal]

* Update reference screenshots sky

Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com>
Co-authored-by: Adrien de Tocqueville <adrien.tocqueville@unity3d.com>
Co-authored-by: Antoine Lelievre <antoinel@unity3d.com>
Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com>
Co-authored-by: skhiat <55133890+skhiat@users.noreply.github.com>
Co-authored-by: JulienIgnace-Unity <julien@unity3d.com>
Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
Co-authored-by: Arttu Peltonen <77337829+arttu-peltonen@users.noreply.github.com>
Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienlagarde sebastienlagarde sebastienlagarde approved these changes

@RemyUnity RemyUnity RemyUnity approved these changes

@fabien-unity fabien-unity fabien-unity approved these changes

@thomas-zeng thomas-zeng thomas-zeng approved these changes

@sandy-carter-unity sandy-carter-unity Awaiting requested review from sandy-carter-unity

Assignees

@alelievr alelievr

Labels
backported-10.x backported-2021.2 HDRP SRP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alelievr @sebastienlagarde @RemyUnity @fabien-unity @thomas-zeng