Skip to content

[HDRP] Backport various Fix Prs #6535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 9, 2021
Merged

[HDRP] Backport various Fix Prs #6535

merged 25 commits into from
Dec 9, 2021

Conversation

sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Dec 8, 2021 •
edited
Loading

Purpose of this PR

Fixed edges and ghosting appearing on shadow matte due to the shado…
Fixed interpolation issue with wind orientation (case 1379841). #6284
Fixed range fields for depth of field #6285
[Core] Fix XR support in CoreUtils.Drawfullscreen #6287
** Fixing DLSS failing when MV are disabled ** (#6292)
[Fix] Lens Flare visible when being behind a camera with Panini Proje…
[HDRP] Remove alpha from local volumetric fog color field #6310
[HDRP] Changed default numbder of physically based sky bounce from 8 …
[HDRP] Improve decal performances when they use different material an…
[HDRP] Update reference screenshots #6404
Fixed Nans happening due to volumetric clouds when the pixel color is…
Fixed missing information in the tooltip of affects smooth surfaces o…
Physically Based Sky documentation now mentions the warmup cost expli…
Reviewed PR #6031 (#6340)
Fix preview scene objects marked dirty by migration #6361
[HDRP][Path Tracing] Fixed PS5 build compilation warnings #6362

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

anisunity and others added 19 commits December 8, 2021 16:02
@anisunity @sebastienlagarde
- Fixed edges and ghosting appearing on shadow matte due to the shado…
12a3936 
…w being black outside the range of the light (case 1371441). #6279
@sebastienlagarde
Merge branch '2021.2/staging' into HDRP/backport-misc-21-2-pr
886b219
@anisunity @sebastienlagarde
Fixed interpolation issue with wind orientation (case 1379841). #6284
3a5b361
@adrien-de-tocqueville @sebastienlagarde
Fixed range fields for depth of field #6285
7ab1b0c
@alelievr @sebastienlagarde
[Core] Fix XR support in CoreUtils.Drawfullscreen #6287
0129228
@kecho @sebastienlagarde
** Fixing DLSS failing when MV are disabled ** (#6292)
ae5ff5f 
* Using texture types instead of RenderTexture types for DLSSPass

* Changelog

* Formatting

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
@skhiat @sebastienlagarde
[Fix] Lens Flare visible when being behind a camera with Panini Proje…
0994b71 
…ction on (case 1370214) (#6293)

* Fix panini for LensFlare

* Add changelog
@sebastienlagarde
Update CHANGELOG.md
cb00e34
@anisunity @sebastienlagarde
Fixed the ray tracing acceleration structure build marker not being i…
30aa0db 
…ncluded in the ray tracing stats (case 1379383). #6277
@alelievr @sebastienlagarde
[HDRP] Remove alpha from local volumetric fog color field #6310
98531f4
@sebastienlagarde
[HDRP] Changed default numbder of physically based sky bounce from 8 …
0c57486 
…to 3 #6304
@alelievr @sebastienlagarde
[HDRP] Improve decal performances when they use different material an…
e2f51a3 
…d the same draw order. #6303
@sebastienlagarde
[HDRP] Update reference screenshots #6404
68066f7
@anisunity @sebastienlagarde
Fixed Nans happening due to volumetric clouds when the pixel color is…
5764d99 
… perfectly black (case 1379185). #6311
@anisunity @sebastienlagarde
Fixed missing information in the tooltip of affects smooth surfaces o…
bb350d3 
…f the ray traced reflections denoiser (case 1376918). #6321
@JulienIgnace-Unity @sebastienlagarde
Physically Based Sky documentation now mentions the warmup cost expli…
e9a5b90 
…citly (#6323)

* Physically Based Sky documentation now mentions the warmup cost explicitly.

* Update CHANGELOG.md

Co-authored-by: sebastienlagarde <sebastien@unity3d.com>
@Vic-Cooper @sebastienlagarde
Reviewed PR #6031 (#6340)
c98a4d3 
* Reviewed PR #6031

Also generally improved this doc, fixed typos and added screenshots.

* Apply formatting changes

Co-authored-by: noreply@unity3d.com <noreply@unity3d.com>
@arttu-peltonen @sebastienlagarde
Fix preview scene objects marked dirty by migration #6361
a046ddc
@eturquin @sebastienlagarde
[HDRP][Path Tracing] Fixed PS5 build compilation warnings #6362
5d0fcd8
@github-actions
Copy link

github-actions bot commented Dec 8, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23PR_HDRP_2021.2
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_2021.2

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%2F_abv.yml%23all_project_ci_2021.2
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde changed the title Hdrp/backport misc 21 2 pr [HDRP] Backport various Fix Prs Dec 8, 2021
@sebastienlagarde sebastienlagarde marked this pull request as ready for review December 9, 2021 08:03
@sebastienlagarde sebastienlagarde merged commit 7f058f1 into 2021.2/staging Dec 9, 2021
@sebastienlagarde sebastienlagarde deleted the HDRP/backport-misc-21-2-pr branch December 9, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienIgnace-Unity JulienIgnace-Unity Awaiting requested review from JulienIgnace-Unity

Assignees
No one assigned
Labels
HDRP SRP testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sebastienlagarde @anisunity @adrien-de-tocqueville @alelievr @kecho @skhiat @JulienIgnace-Unity @Vic-Cooper @arttu-peltonen @eturquin