Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 4, 2022

Proposed changes (including videos or screenshots)

Before

image

After

Screen Shot 2022-08-04 at 16 49 15

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team as a code owner August 4, 2022 19:45
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@9e5c9a2). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #26478   +/-   ##
==========================================
  Coverage           ?   38.07%           
==========================================
  Files              ?      749           
  Lines              ?    18666           
  Branches           ?     1457           
==========================================
  Hits               ?     7107           
  Misses             ?    11335           
  Partials           ?      224           
Flag Coverage Δ
e2e 38.07% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 5, 2022
@dougfabris dougfabris added this to the 5.1.0 milestone Aug 5, 2022
@dougfabris dougfabris added eng day and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 5, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 5, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 8, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 8, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 8, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 9, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 9, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

…e/refactor-reportMessage-modal

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  Chore: Bypass turbo cache on `ui-contexts` (#26526)
  Chore: Refactor WebdavFilePicker Modal to React Component (#26422)
  [FIX] Chats holds to load history for some time (#26425)
  [FIX] Decrypt E2EE messages on thread list (#26133)
  Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498)
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 9, 2022
@kodiakhq kodiakhq bot merged commit db94a20 into develop Aug 9, 2022
@kodiakhq kodiakhq bot deleted the chore/refactor-reportMessage-modal branch August 9, 2022 21:39
gabriellsh added a commit that referenced this pull request Aug 12, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (34 commits)
  Chore: update fuselage rounded edition  (#26540)
  [FIX] LDAP fails to sync teams when the user DN has escaped characters. (#26535)
  [FIX] Allow normal user to open apps contextual bar (#26495)
  Chore: restrict `.only` (#26537)
  [FIX] Endpoints not working when using "Use Real Name" setting (#26530)
  [NEW] `Home` page (#25734)
  Chore: ModalFooterControllers adoption (#26445)
  Chore: create roomNameExists endpoint (#26386)
  Chore: Improve test for livechat  (#26527)
  Chore: Fix UiKit dependency issue for Livechat (#26534)
  [FIX] Too many REST API requests (#26330)
  Chore: Mocha handling multiple React instances (#26513)
  Chore: Convert `LivechatCustomField` model to raw model (#26446)
  i18n: Language update from LingoHub 🤖 on 2022-08-08Z (#26508)
  [FIX] Open team after room not found page (#26264)
  Chore: Refactor ReportMessage Modal to React Component (#26478)
  Chore: Fix lint issues (#26531)
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants