Skip to content

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Jul 29, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Closes #24385
Closes #24775
Closes #24128

Steps to test or reproduce

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2022

This pull request introduces 6 alerts when merging 6a8633a into b11bab5 - view on LGTM.com

new alerts:

  • 6 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2022

This pull request introduces 3 alerts when merging a28ef34 into a97e926 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@dougfabris dougfabris marked this pull request as ready for review August 8, 2022 17:37
@dougfabris dougfabris requested review from a team as code owners August 8, 2022 17:37
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #26422 (b385592) into develop (f79e8ed) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #26422   +/-   ##
========================================
  Coverage    38.05%   38.05%           
========================================
  Files          745      745           
  Lines        18625    18622    -3     
  Branches      1412     1412           
========================================
  Hits          7087     7087           
+ Misses       11318    11314    -4     
- Partials       220      221    +1     
Flag Coverage Δ
e2e 38.05% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 9, 2022
@kodiakhq kodiakhq bot merged commit 37d8f59 into develop Aug 9, 2022
@kodiakhq kodiakhq bot deleted the chore/webdavFilePicker branch August 9, 2022 14:14
gabriellsh added a commit that referenced this pull request Aug 9, 2022
…homepage

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Bypass turbo cache on `ui-contexts` (#26526)
  Chore: Refactor WebdavFilePicker Modal to React Component (#26422)
  [FIX] Chats holds to load history for some time (#26425)
  [FIX] Decrypt E2EE messages on thread list (#26133)
  Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498)
  Chore: Convert `client/views/account/preferences` folder to ts (#26496)
gabriellsh added a commit that referenced this pull request Aug 9, 2022
…e/refactor-reportMessage-modal

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  Chore: Bypass turbo cache on `ui-contexts` (#26526)
  Chore: Refactor WebdavFilePicker Modal to React Component (#26422)
  [FIX] Chats holds to load history for some time (#26425)
  [FIX] Decrypt E2EE messages on thread list (#26133)
  Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498)
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

2 participants