Skip to content

Conversation

@albuquerquefabio
Copy link
Contributor

@albuquerquefabio albuquerquefabio commented Mar 8, 2022

Proposed changes (including videos or screenshots)

Rewritten OTR files to TS with new code patterns

Issue(s)

Steps to test or reproduce

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Mar 10, 2022

This pull request introduces 1 alert when merging 8b898c1 into 1172f45 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@debdutdeb debdutdeb force-pushed the improve/otr-refactoring branch from a40ab15 to 82f4ee7 Compare May 15, 2022 20:54
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jul 26, 2022
@tassoevan tassoevan modified the milestone: Mid-term Aug 3, 2022
@kodiakhq kodiakhq bot merged commit d9422aa into develop Aug 9, 2022
@kodiakhq kodiakhq bot deleted the improve/otr-refactoring branch August 9, 2022 18:03
gabriellsh added a commit that referenced this pull request Aug 9, 2022
… new/homepage

* 'new/homepage' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
gabriellsh added a commit that referenced this pull request Aug 9, 2022
…e/refactor-reportMessage-modal

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  Chore: Bypass turbo cache on `ui-contexts` (#26526)
  Chore: Refactor WebdavFilePicker Modal to React Component (#26422)
  [FIX] Chats holds to load history for some time (#26425)
  [FIX] Decrypt E2EE messages on thread list (#26133)
  Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498)
gabriellsh added a commit that referenced this pull request Aug 12, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (34 commits)
  Chore: update fuselage rounded edition  (#26540)
  [FIX] LDAP fails to sync teams when the user DN has escaped characters. (#26535)
  [FIX] Allow normal user to open apps contextual bar (#26495)
  Chore: restrict `.only` (#26537)
  [FIX] Endpoints not working when using "Use Real Name" setting (#26530)
  [NEW] `Home` page (#25734)
  Chore: ModalFooterControllers adoption (#26445)
  Chore: create roomNameExists endpoint (#26386)
  Chore: Improve test for livechat  (#26527)
  Chore: Fix UiKit dependency issue for Livechat (#26534)
  [FIX] Too many REST API requests (#26330)
  Chore: Mocha handling multiple React instances (#26513)
  Chore: Convert `LivechatCustomField` model to raw model (#26446)
  i18n: Language update from LingoHub 🤖 on 2022-08-08Z (#26508)
  [FIX] Open team after room not found page (#26264)
  Chore: Refactor ReportMessage Modal to React Component (#26478)
  Chore: Fix lint issues (#26531)
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  ...
@alvaropmello alvaropmello added this to the 5.1.0 milestone Aug 16, 2022
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: OTR stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants