Skip to content

Conversation

@yash-rajpal
Copy link
Member

Proposed changes (including videos or screenshots)

#24757 was an old PR and was recently auto-merged, it was not following our latest eslint rules, so now there are some lint issues on the develop.

Issue(s)

Steps to test or reproduce

Further comments

@yash-rajpal yash-rajpal requested a review from a team August 9, 2022 20:06
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Aug 9, 2022
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @yash-rajpal .. changing title to Chore 😉

@sampaiodiego sampaiodiego changed the title [FIX] Lint on develop Chore: Fix lint issues Aug 9, 2022
@kodiakhq kodiakhq bot merged commit 9e5c9a2 into develop Aug 9, 2022
@kodiakhq kodiakhq bot deleted the fix/lint branch August 9, 2022 20:52
gabriellsh added a commit that referenced this pull request Aug 12, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (34 commits)
  Chore: update fuselage rounded edition  (#26540)
  [FIX] LDAP fails to sync teams when the user DN has escaped characters. (#26535)
  [FIX] Allow normal user to open apps contextual bar (#26495)
  Chore: restrict `.only` (#26537)
  [FIX] Endpoints not working when using "Use Real Name" setting (#26530)
  [NEW] `Home` page (#25734)
  Chore: ModalFooterControllers adoption (#26445)
  Chore: create roomNameExists endpoint (#26386)
  Chore: Improve test for livechat  (#26527)
  Chore: Fix UiKit dependency issue for Livechat (#26534)
  [FIX] Too many REST API requests (#26330)
  Chore: Mocha handling multiple React instances (#26513)
  Chore: Convert `LivechatCustomField` model to raw model (#26446)
  i18n: Language update from LingoHub 🤖 on 2022-08-08Z (#26508)
  [FIX] Open team after room not found page (#26264)
  Chore: Refactor ReportMessage Modal to React Component (#26478)
  Chore: Fix lint issues (#26531)
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants