Skip to content

Conversation

@sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Since we've pushing to have more and more tests, this rule is a good one to prevent .only from being merged by mistake.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner August 10, 2022 19:25
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #26537 (e0780a0) into develop (6953c06) will decrease coverage by 0.19%.
The diff coverage is n/a.

❗ Current head e0780a0 differs from pull request most recent head 39b5dff. Consider uploading reports for the commit 39b5dff to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26537      +/-   ##
===========================================
- Coverage    38.11%   37.92%   -0.20%     
===========================================
  Files          759      759              
  Lines        18831    18831              
  Branches      1459     1459              
===========================================
- Hits          7178     7142      -36     
- Misses       11428    11461      +33     
- Partials       225      228       +3     
Flag Coverage Δ
e2e 37.92% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 10, 2022
@kodiakhq kodiakhq bot merged commit 15b0931 into develop Aug 10, 2022
@kodiakhq kodiakhq bot deleted the eslint-restrict-only branch August 10, 2022 21:32
gabriellsh added a commit that referenced this pull request Aug 12, 2022
…hreads

* 'develop' of github.com:RocketChat/Rocket.Chat: (34 commits)
  Chore: update fuselage rounded edition  (#26540)
  [FIX] LDAP fails to sync teams when the user DN has escaped characters. (#26535)
  [FIX] Allow normal user to open apps contextual bar (#26495)
  Chore: restrict `.only` (#26537)
  [FIX] Endpoints not working when using "Use Real Name" setting (#26530)
  [NEW] `Home` page (#25734)
  Chore: ModalFooterControllers adoption (#26445)
  Chore: create roomNameExists endpoint (#26386)
  Chore: Improve test for livechat  (#26527)
  Chore: Fix UiKit dependency issue for Livechat (#26534)
  [FIX] Too many REST API requests (#26330)
  Chore: Mocha handling multiple React instances (#26513)
  Chore: Convert `LivechatCustomField` model to raw model (#26446)
  i18n: Language update from LingoHub 🤖 on 2022-08-08Z (#26508)
  [FIX] Open team after room not found page (#26264)
  Chore: Refactor ReportMessage Modal to React Component (#26478)
  Chore: Fix lint issues (#26531)
  [FIX] Don't wrap wrap up notes (#26375)
  [IMPROVE] OTR refactoring (#24757)
  [FIX] Prevent VoIP issues during disconnection when network failed (#26321)
  ...
@murtaza98 murtaza98 mentioned this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants