Skip to content

Chore: restrict .only #26537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Aug 10, 2022
Merged

Chore: restrict .only #26537

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0780a0
restrict .only
sampaiodiego Aug 10, 2022
39b5dff
Merge branch 'develop' into eslint-restrict-only
kodiakhq[bot] Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 17 additions & 41 deletions packages/eslint-config/best-practices/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,47 +192,23 @@ module.exports = {
// disallow declaring the same variable more then once
'no-redeclare': 'error',

// // disallow certain object properties
// // https://eslint.org/docs/rules/no-restricted-properties
// 'no-restricted-properties': ['error', {
// object: 'arguments',
// property: 'callee',
// message: 'arguments.callee is deprecated',
// }, {
// object: 'global',
// property: 'isFinite',
// message: 'Please use Number.isFinite instead',
// }, {
// object: 'self',
// property: 'isFinite',
// message: 'Please use Number.isFinite instead',
// }, {
// object: 'window',
// property: 'isFinite',
// message: 'Please use Number.isFinite instead',
// }, {
// object: 'global',
// property: 'isNaN',
// message: 'Please use Number.isNaN instead',
// }, {
// object: 'self',
// property: 'isNaN',
// message: 'Please use Number.isNaN instead',
// }, {
// object: 'window',
// property: 'isNaN',
// message: 'Please use Number.isNaN instead',
// }, {
// property: '__defineGetter__',
// message: 'Please use Object.defineProperty instead.',
// }, {
// property: '__defineSetter__',
// message: 'Please use Object.defineProperty instead.',
// }, {
// object: 'Math',
// property: 'pow',
// message: 'Use the exponentiation operator (**) instead.',
// }],
// disallow certain object properties
// https://eslint.org/docs/rules/no-restricted-properties
'no-restricted-properties': [
'error',
{
object: 'describe',
property: 'only',
},
{
object: 'it',
property: 'only',
},
{
object: 'context',
property: 'only',
},
],

// disallow use of assignment in return statement
'no-return-assign': ['error', 'always'],
Expand Down