Chore: Migrate AppPermissionsReviewModal from JS to TS #26498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
added
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #26498 +/- ##
===========================================
- Coverage 38.09% 37.95% -0.14%
===========================================
Files 745 745
Lines 18622 18628 +6
Branches 1418 1419 +1
===========================================
- Hits 7094 7071 -23
- Misses 11307 11335 +28
- Partials 221 222 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
approved these changes
Aug 8, 2022
gabriellsh
added a commit
that referenced
this pull request
Aug 9, 2022
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Bypass turbo cache on `ui-contexts` (#26526) Chore: Refactor WebdavFilePicker Modal to React Component (#26422) [FIX] Chats holds to load history for some time (#26425) [FIX] Decrypt E2EE messages on thread list (#26133) Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498) Chore: Convert `client/views/account/preferences` folder to ts (#26496)
gabriellsh
added a commit
that referenced
this pull request
Aug 9, 2022
…e/refactor-reportMessage-modal * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Don't wrap wrap up notes (#26375) [IMPROVE] OTR refactoring (#24757) [FIX] Prevent VoIP issues during disconnection when network failed (#26321) Chore: Bypass turbo cache on `ui-contexts` (#26526) Chore: Refactor WebdavFilePicker Modal to React Component (#26422) [FIX] Chats holds to load history for some time (#26425) [FIX] Decrypt E2EE messages on thread list (#26133) Chore: Migrate AppPermissionsReviewModal from JS to TS (#26498)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments