Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(translation): migrate code from googleapis/python-translate #8523

Merged
merged 273 commits into from
Nov 18, 2022
Merged

chore(translation): migrate code from googleapis/python-translate #8523

merged 273 commits into from
Nov 18, 2022

Conversation

telpirion
Copy link
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

merla18 and others added 30 commits July 31, 2020 16:23
@merla18 @danoscarmike
renaming of the product to Google Translation API [(#910)](#910)
eb8193f
@danoscarmike
Update translate readme
33486ac
@danoscarmike
Re-generate all readmes
9c7ebc6
@waprin @danoscarmike
Fix README rst links [(#962)](#962)
cbe8a44 
* Fix README rst links

* Update all READMEs
@dpebot @danoscarmike
Auto-update dependencies. [(#1004)](#1004)
f5ae2eb 
* Auto-update dependencies.

* Fix natural language samples

* Fix pubsub iam samples

* Fix language samples

* Fix bigquery samples
@dpebot @danoscarmike
Auto-update dependencies. [(#1055)](#1055)
6069a51 
* Auto-update dependencies.

* Explicitly use latest bigtable client

Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e

* Revert language update for now

Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53

* Remove pdb. smh

Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43
@dpebot @danoscarmike
Auto-update dependencies. [(#1093)](#1093)
12b5d23 
* Auto-update dependencies.

* Fix storage notification poll sample

Change-Id: I6afbc79d15e050531555e4c8e51066996717a0f3

* Fix spanner samples

Change-Id: I40069222c60d57e8f3d3878167591af9130895cb

* Drop coverage because it's not useful

Change-Id: Iae399a7083d7866c3c7b9162d0de244fbff8b522

* Try again to fix flaky logging test

Change-Id: I6225c074701970c17c426677ef1935bb6d7e36b4
@danoscarmike
Update all generated readme auth instructions [(#1121)](#1121)
dd1c0d4 
Change-Id: I03b5eaef8b17ac3dc3c0339fd2c7447bd3e11bd2
@danoscarmike
Added Link to Python Setup Guide [(#1158)](#1158)
7b4c588 
* Update Readme.rst to add Python setup guide

As requested in b/64770713.

This sample is linked in documentation https://cloud.google.com/bigtable/docs/scaling, and it would make more sense to update the guide here than in the documentation.

* Update README.rst

* Update README.rst

* Update README.rst

* Update README.rst

* Update README.rst

* Update install_deps.tmpl.rst

* Updated readmegen scripts and re-generated related README files

* Fixed the lint error
@dpebot @danoscarmike
Auto-update dependencies. [(#1186)](#1186)
7bbfa6b
@danoscarmike
Fixed failed tests on Kokoro (Spanner + Translate) [(#1192)](#1192)
7ec7aa3 
* Fixed failed tests on Kokoro (Spanner + Translate)

* Update quickstart_test.py
@danoscarmike
Added "Open in Cloud Shell" buttons to README files [(#1254)](#1254)
44b5ead
@dpebot @danoscarmike
Auto-update dependencies. [(#1377)](#1377)
94a75f0 
* Auto-update dependencies.

* Update requirements.txt
@danoscarmike
Regenerate the README files and fix the Open in Cloud Shell link for …
de569d7 
…some samples [(#1441)](#1441)
@frankyn @danoscarmike
Update READMEs to fix numbering and add git clone [(#1464)](#1464)
19b9f90
@averikitsch @danoscarmike
Add translate region tags [(#1488)](#1488)
05292a4 
* Add region tags

* Added end region tags

* Linting errors fixed
@engelke @danoscarmike
Include the comma in the translation [(#1787)](#1787)
7e0d9a3
@dpebot @danoscarmike
Auto-update dependencies. [(#1980)](#1980)
61cbba7 
* Auto-update dependencies.

* Update requirements.txt

* Update requirements.txt
@beccasaurus @danoscarmike
Translation v3beta1 samples [(#2084)](#2084)
a5be14a 
* Add in progress beta snippets

Change-Id: I2cd8ddc2307a8e40d56ce7e493749dc05c34d164

* Add google-cloud-storage dependency

Change-Id: Iff7bc9b2c82b1e829580a3d4ad628087dbeee8be

* Non-'global' location required for BatchTranslateText

Change-Id: I5198aa6368a088e8f5ee295dc55a5e9e4ca8f494

* Upgrade google-cloud-translate to 1.4.0

1.4.0 includes the new v3beta1 alongside V2

Change-Id: I5adfe78ea7e78d84678db343cd84516e3d05491f

* Update Translate samples

You can now provide your own glossary ID

The tests now run within a randomly created bucket (deleted after each
test)

Change-Id: I5cb2680cd0e9e43c85932a6a0dc19e6fab5008c5

* pytest.fixture for random test bucket

Change-Id: I8e816ed4c95a6235347a29849044b4cab02d40a8

* flake8 spec fixes

Change-Id: I4932bcf856a9498b01d9661c90c6b45ee2958ee1

* Added pytest fixture for creating glossary (WIP)

Change-Id: Iddb5ecbf0eefb9efd2243dc4bc56b585102e9351

* Add assertions, remove placeholder TODOs

Change-Id: If1eb20bca5bfcc87dd0652d5488b2188afa626af
@crowdus @danoscarmike
fixing translate-with-glossary bug [(#2323)](#2323)
fe60e6e
@crowdus @danoscarmike
Translate beta samples fix [(#2327)](#2327)
123c2d6 
* fixing translate-with-glossary bug

* tests passing

* reverting to python3 compatibility

* snippets test fix
@crowdus @danoscarmike
Using glossaries with tts and vision tutorial sample code [(#2325)](#…
0fdc938 
…2325)

* fixing translate-with-glossary bug

* initial commit

* adding resources

* adding more resources

* glossary accomodates upper case words

* finished hybrid glossaries tutorial sample code

* Revert "fixing translate-with-glossary bug"

This reverts commit 6a9f7ca.

* lint fix for tests. TODO src lint fix

* lint

* it's the final lint-down

* adding README

* implementing @nnegrey's feedback

* lint

* lint

* extracting files from cloud-client

* lint comment test

* fixing comments per @beccasaurus

* removing redundant directory

* implementing @nnegrey's feedback

* lint

* lint

* handling glossary-already-exists exception

* lint

* adding ssml functionality

* fixing imports per @nnegrey

* fixed import comment

* more specific exceptions import

* removing period from copyright
@crowdus @danoscarmike
fix: refactored MP3 file creation test for Hybrid glossaries samples [(…
629e511 
…#2379)](#2379)

* fix: refactored MP3 file creation test

* fix: lint
@nnegrey @danoscarmike
Fix variable names in comments [(#2400)](#2400)
7f237df
@gguuss @danoscarmike
Adds updates for samples profiler ... vision [(#2439)](#2439)
237e75c
@nnegrey @danoscarmike
Update v2 samples to explicitly use v2 library [(#2498)](#2498)
b389f55
@leahecole @danoscarmike
fix: translate test [(#2671)](#2671)
d909a9d 
* fix: translate test

* Add unicode formatting
@nnegrey @danoscarmike
automl: add natural language sentiment analysis ga samples [(#2677)](#…
4c7db15 
…2677)

* automl: add natural language sentiment analysis ga samples

* Add links to documentation

* Update tests to use centralized project

* Fix environment variable, make translate test less flaky
@leahecole @danoscarmike
fix region tag typo [(#2731)](#2731)
e0f3482
@texasmichelle @danoscarmike
Migrate published samples [(#2759)](#2759)
99f37b2 
Migrate from tmp-generated-samples branch 615c08e
Remove boilerplate
Update copyright date
Blacken
Remove unused imports
Shorten docstrings
Remove CLI
Set defaults in function definition
Add link to supported types guide
Inline function arguments
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@telpirion telpirion closed this Nov 17, 2022
@telpirion telpirion reopened this Nov 18, 2022
@telpirion telpirion added api: translate Issues related to the Cloud Translation API. api: translation Issues related to the Cloud Translation API API. labels Nov 18, 2022
@telpirion telpirion marked this pull request as ready for review November 18, 2022 18:13
@telpirion telpirion requested review from a team as code owners November 18, 2022 18:13
@telpirion telpirion changed the title migrate code from googleapis/python-translate chore(translation): migrate code from googleapis/python-translate Nov 18, 2022
@snippet-bot
Copy link

snippet-bot bot commented Nov 18, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 28 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 18, 2022
@telpirion
Copy link
Contributor Author

Set this to "Ready for Review" too soon -- still need to remove old / unused samples.

dandhlee
dandhlee requested changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename the directory to be translate? This change was made to rename from python-translation to python-translate.

translation/samples/generated_samples/snippet_metadata_translate_v3.json Outdated
@@ -0,0 +1,1728 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snippetgen samples are not in scope, please remove this directory and keep it in the old repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

translation/samples/snippets/noxfile.py Outdated
@@ -0,0 +1,312 @@
# Copyright 2019 Google LLC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@telpirion telpirion requested a review from nicain as a code owner November 18, 2022 18:45
@telpirion telpirion removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 18, 2022
@telpirion
Copy link
Contributor Author

Could you rename the directory to be translate? This change was made to rename from python-translation to python-translate.

The name of the product is Cloud Translation. See: https://cloud.google.com/translate/docs/

@dandhlee
Copy link
Collaborator

The name of the product is indeed Translation but the shortname is translate. Indeed strange, but I'd prefer to be consistent.

@telpirion telpirion requested a review from dandhlee November 18, 2022 18:52
@telpirion
Copy link
Contributor Author

After conferring with @nicain on preferred branding, I've changed the folder name.

dandhlee
dandhlee approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Overriding CLA and merging.

@dandhlee dandhlee merged commit 2073cb5 into main Nov 18, 2022
@dandhlee dandhlee deleted the python-translate-migration branch November 18, 2022 21:13
@telpirion telpirion mentioned this pull request Dec 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@nicain nicain Awaiting requested review from nicain

Assignees

@dandhlee dandhlee

Labels
api: translate Issues related to the Cloud Translation API. api: translation Issues related to the Cloud Translation API API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

appengine/taskqueue/pull-counter Needs Worker Tests