Close HappyBase connection in bigtable/hello sample. #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
wow not sure why travis is suddenly unhappy about those appengine snippets, will take a look. code lgtm, though a bit surprised the change is necessary. do you think we need an issue on the client lib? |
|
Once #378 is merged just rebase on that. |
I noticed that the `bigtable/hello` sample was not quitting when I sent a `Ctrl-C` this should fix that problem.
|
Rebased. I'm not sure it warrants an issue on the client. I started using the "raw" apis without this problem and then encountered it after converting to the happybase package. I think the HappyBase layer starts some background threads or something that I needed to explicitly close that connection, not just the underlying client. |
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
* fix: adding a noxfile_config.py to snippets to balance load between different projects * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * disabling type hint enforcement in noxfile_config * changing the method of disabling type checking * linter on samples * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * changing transport logic for submit_job_to_cluster.py * updating transport method in list_clusters.py * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
8 tasks
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 441524537 Source-Link: googleapis/googleapis@2a27391 Source-Link: https://github.com/googleapis/googleapis-gen/commit/ab6756a48c89b5bcb9fb73443cb8e55d574f4643 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWI2NzU2YTQ4Yzg5YjViY2I5ZmI3MzQ0M2NiOGU1NWQ1NzRmNDY0MyJ9 docs: fix type in docstring for map fields
dandhlee
pushed a commit
that referenced
this pull request
Nov 18, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 441524537 Source-Link: googleapis/googleapis@2a27391 Source-Link: googleapis/googleapis-gen@ab6756a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWI2NzU2YTQ4Yzg5YjViY2I5ZmI3MzQ0M2NiOGU1NWQ1NzRmNDY0MyJ9 docs: fix type in docstring for map fields
engelke
pushed a commit
that referenced
this pull request
Nov 28, 2022
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
dandhlee
pushed a commit
that referenced
this pull request
Nov 29, 2022
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
8 tasks
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
Source-Link: googleapis/synthtool@f15cc72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
dizcology
pushed a commit
that referenced
this pull request
Jun 16, 2023
9 tasks
dizcology
pushed a commit
that referenced
this pull request
Jul 10, 2023
leahecole
pushed a commit
that referenced
this pull request
Jul 11, 2023
dizcology
pushed a commit
that referenced
this pull request
Sep 11, 2023
9 tasks
leahecole
pushed a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
bigtable/hellosample was not quitting when I senta
Ctrl-Cthis should fix that problem.