-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added script that manages a set of rolling backups. #381
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@@ -0,0 +1,152 @@ | |||
#!/usr/bin/python | |||
|
|||
# pip install --upgrade google-api-python-client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move these to a requirements.txt
file.
@aegrumet finished a first pass. Let me know when you're ready for another round and feel free to reach out if you have any questions. We'll also have to get a test written here, but let's resolve my existing comments first. |
Updated with all requested changes. Test cases still TODO. |
import pytz | ||
|
||
|
||
DISK_ZONE_MAP = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two newlines after this, please.
This is looking good, do you want to take a stab at writing tests or do you want to leave that to us? |
Happy to give it a shot -- feel free to point me to any existing test code Also, just as a heads up, I typically iterate on this code outside of work On Mon, Jun 27, 2016 at 9:52 AM, Jon Wayne Parrott <notifications@github.com
|
This entire repository is managed by nox. I'd pattern your tests after this one. Once you create that file, you can run the tests for just that sample using:
There's big guide in TESTING.md but that's more for testing the whole shebang. Feel free to reach out to me via Hangouts if you need help getting things up and running.
No worries. It'll go at whatever pace you feel comfortable with. |
Closing this as it's rather old, if you're still interested in contributing this, please feel free to re-open or open a new PR. |
Source-Link: googleapis/synthtool@1b71c10 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@1b71c10 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chore: Adding support for pytest-xdist and pytest-parallel Source-Link: googleapis/synthtool@38e11ad Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3
chore: Adding support for pytest-xdist and pytest-parallel Source-Link: googleapis/synthtool@38e11ad Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3
No description provided.