-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session for gRPC samples. #385
Conversation
These samples are being excluded from the plain `tests` target, since they require the gRPC libraries (which are not compatible with Python 3, yet). This means they are not running on Jenkins or Travis. By adding another session, we will be able to run the tests for these samples on Jenkins.
@waprin @jonparrott I noticed that neither
|
Huh - in theory, the speech tests should only be skipped if the python version was > 3... was that not working? |
The speech directory was in the "blacklist" so nox was never considering them to be sample directories. (Ditto for bigtable.) |
Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
Source-Link: googleapis/synthtool@6ed3a83 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link: googleapis/synthtool@6ed3a83 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
These samples are being excluded from the plain
tests
target, sincethey require the gRPC libraries (which are not compatible with Python
3, yet). This means they are not running on Jenkins or Travis.
By adding another session, we will be able to run the tests for these
samples on Jenkins.