Skip to content

Tests use magic numbers #85

Closed
Closed
@waprin

Description

@waprin

https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/appengine/images/tests/test_guestbook.py

Code cleanup: HTTP requests should be named constants.

Others might feel that HTTP codes are well known enough to not be "magic". I think this would be slight code cleanup but if there's loud objections we can leave it as is.

httplib contains the constants so we can use those.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    🚨This issue needs some love.help wantedWe'd love to have community involvement on this issue.triage meI really want to be triaged.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions