Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

chore(samples): deleting migrated samples #468

Merged
merged 2 commits into from
Dec 5, 2022
Merged

chore(samples): deleting migrated samples #468

merged 2 commits into from
Dec 5, 2022

Conversation

telpirion
Copy link
Contributor

This PR removes the samples that have been migrated to GoogleCloudPlatform/python-docs-samples in this PR.

@snippet-bot
Copy link

snippet-bot bot commented Dec 2, 2022

Here is the summary of changes.

You are about to delete 42 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: translate Issues related to the googleapis/python-translate API. samples Issues that are directly related to samples. labels Dec 2, 2022
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit.

@@ -0,0 +1,5 @@
# Samples for python-translate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to move this down to samples/snippets/ instead of samples/?

@telpirion telpirion merged commit 2eda3b3 into main Dec 5, 2022
@telpirion telpirion deleted the delete-samples branch December 5, 2022 17:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: translate Issues related to the googleapis/python-translate API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants