cope with conflicts #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-link-resource`: Migrate eventhubs namespace private-endpoint-connection cmdlets to AAZ (#25946) * Updates * updates Ci's fixes * ci's fixesssss * Added meaningful description. * updates * Updates * UPdates
… has no attribute 'resource' (#26040)
…/show/list`: Migrate eventhub consumer-group cmdlets to AAZ (#25989) * Updates * minor update * CI's fixes * updates * UPdates
* register blob arguments with track2 SDK for adding --blob-url * sync tests
…mand (#26053) * {AzureBotService} fix for the AttributeError in 'az bot show' CLI command Fixes #26037 While running the CLI command `az bot show -n botnaem -g rsourcegroupname --msbot` we get the below error: ``` File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 697, in _run_job File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 333, in call File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 363, in handler File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/arm.py", line 429, in show_exception_handler File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 361, in handler File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/botservice/custom.py", line 179, in get_bot File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/botservice/bot_json_formatter.py", line 94, in create_bot_json AttributeError: 'AzureBotService' object has no attribute 'config' ``` THis PR has the fix for the above error. * Update bot_json_formatter.py * Update bot_json_formatter.py
…the AttributeError `'function' object has no attribute 'metadata'` (#26078)
… for `--enable-tcp-reset` and `--idle-timeout` (#26070)
* batch ci notify * Update notify_ci_errors.py * Update notify_ci_errors.py * update * Update azure-pipelines-full-tests.yml * update
* CLI support for ledger in MI * changes * add test for create api * tests and recordings * fix spaces * update test recordings --------- Co-authored-by: Parameswara Reddy Bodeddula <pbodeddula@microsoft.com>
* Update onboarding_guide.md * Update doc/onboarding_guide.md
…e\namespace list\list\wait\show`: Migrate eventhubs cluster cmdlets to AAZ (#26092) * Updates * 'Updartes * 'Updartes
…Add upcoming breaking change notification (#26041) * Breaking change * updates * CI's fixed * Update src/azure-cli/azure/cli/command_modules/eventhubs/custom.py Co-authored-by: Yishi Wang <yishiwang@microsoft.com> * Updates * Updates --------- Co-authored-by: Yishi Wang <yishiwang@microsoft.com>
…missing in public IP address (#26135)
…le mode improvement (#26133) * remove the validation of SQL VM management mode because it is deprecated. Now there is no management mode concept in SQL VM. * fix the test --------- Co-authored-by: Qiang Liu <qianliu@microsoft.com>
…rate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ (#25118) * Eventhub-namespace,Eventhub AuthRule * CI's Fixes * More CI fixes * Updates * CI's fixes * CI fixes * ci agaaaaaaaaaaaaaaaaaaaaaain * CI's fixes again * CI's fixessssssssssssssssssssss * updates * updates * updates * Hybrid profile test_iot_command.py succeeded * Recording added * CI's fixes again * UPdates * UPdates * UPdates * Updates * updatess removed --yes confirmation
… parameter to allow app setting operation on preview environments (#25997)
* telemetry default push interval changed from 24h to 6h * fix test
…with HTTP 400 (#26452)
…grating Eventhub Entity cmdlets to AAZ (#26168) * UPdates * UPdates * External service recordings * external test failures * Update custom.py * downgrading api version for python sdk * recordings * recordings * iot hub recording * pipeline fix * fix * fix * Updates * fixes * Updates * UPdates * Revert "UPdates" This reverts commit db1bc1f. * UPdates * CI's Againnnnnnnnnn * fixing cli style error --------- Co-authored-by: unknown <davadhani@microsoft.com>
… command group to manage blob cors rules (#26447) * az storage account blob-service-properties cors-rule: New command group to manage blob cors rules * fix linter * fix style
…becomes required for MHSM creation (#26423) * az keyvault create: --retention-days becomes required for MHSM creation * fix network tests
…ttings (#26422) * �z keyvault setting: New command group to manage MHSM settings * fix linter * re-record test * fix style
…st/show/update` `az eventhubs namespace application-group policy add/remove`: Migrating eventhub application-group cmdlets to AAZ (#26032) * Updates * Updates * Updates76 * Updates77 * fixes and optimization * rename * fixing comments * updates * Update commands.py * recordings * ci's fixes * ci's fixes again * ci's fixes againnn * ci's fixes againnnn * ci's fixesss * Adding correct errrors * Recording * SDK based custom file deleted * cli style error fixed * Updates --------- Co-authored-by: unknown <davadhani@microsoft.com>
* update * update
… to track2 SDK, breaking changes to service response (#26242) * add track2 sdk for keyvault certificates and secrets * tested `secret list/list-deleted/list-versions`, `secret set` is partially done * `az keyvault secret set` done * `az keyvault secret set-attributes` done * `az keyvault secret show` done, reformat _params.py * `az keyvault secret show-deleted` done * `az keyvault secret delete` done * `az keyvault secret purge` done * `az keyvault secret purge` done * `az keyvault secret recover` done * `az keyvault secret download` done * `az keyvault secret backup` done * `az keyvault secret restore` done , `az keyvault secret` done, still need tests * `az keyvault secret` tests passed * `az keyvault certificate create` done * `az keyvault certificate list` done * `az keyvault certificate list-versions` done * `az keyvault certificate list-deleted` done * `az keyvault certificate show` done * `az keyvault certificate show` done * `az keyvault certificate show-deleted` done * `az keyvault certificate delete` done * `az keyvault certificate purge` done * `az keyvault certificate recover` done * `az keyvault certificate set-attributes` done * `az keyvault certificate set-attributes` done * `az keyvault certificate import` done, need to fix x509properties,basic_constraints * `az keyvault certificate import` no need for custom func * `az keyvault certificate download` done * remove basic_constraints as no longer return by track2 sdk * `az keyvault certificate get-default-policy` done * `az keyvault certificate backup` done * `az keyvault certificate restore` done * `az keyvault certificate pending merge` done, testing not finished because (Conflict) A pending object is already complete. BREAKING CHANGE: --not-before and --expires no longer supported by track2 * `az keyvault certificate pending show` done * `az keyvault certificate pending delete` done * `az keyvault certificate contact list` done * `az keyvault certificate contact add` done * `az keyvault certificate contact delete` done, BREAKING CHANGE, if delete would remove the last contact, return an empty list instead of the deleted contact. This is to be consistent where delete would return the remaining list. * `az keyvault certificate issuer create` done, BREAKING CHANGE, "zip" under "organizationDetails" is no longer returned, use 0 as default * `az keyvault certificate issuer update` done * `az keyvault certificate issuer list` done * `az keyvault certificate issuer show` done * `az keyvault certificate issuer delete` done * `az keyvault certificate issuer admin add` done, BREAKING CHANGE: returns the list after the addition instead of only the admin just added, follows `az keyvault certificate contact add` * `az keyvault certificate issuer admin list` done * `az keyvault certificate issuer admin delete` done, fix case when the admin deleted is the last * fix some tests, test_keyvault_certificate_issuers still not fully working because of sdk breaking change * lint * use sdk functions directly to bypass error where cannot set str back to "", remove breaking change for `az keyvault certificate admin add` * pylint fix * Rerun tests from instance 7. See test_results_None_latest_7.parallel.xml for details * Rerun tests from instance 1. See test_results_None_latest_1.serial.xml for details * Rerun tests from instance 2. See test_results_None_latest_2.parallel.xml for details * Rerun tests from instance 3. See test_results_None_latest_3.parallel.xml for details * pylint fix * fix validator for cert policy * fix recordings * fix recordings * Rerun tests from instance 3. See test_results_None_latest_3.parallel.xml for details * fix recordings * fix recordings * fix recordings * fix recordings * fix recordings * old api version keyvault has no soft delete * old api version keyvault mgmt plane has no soft delete * try to fix recording again * BREAKING CHANGE: pending not return by SDK anymore as it is an additional property, should not manually add it, user can use `az keyvault certificate pending show` to find it. * fix recording --------- Co-authored-by: Azure CLI Team <AzPyCLI@microsoft.com>
…trigger, output versioning options (#26261)
…es must be integers` (#26363)
…nable-msi-auth-for-monitoring` to true and add check for airgap clouds (#26356)
…ly used, cannot rerun to record test (#26476)
…ecurity context for confidential ContainerGroupSku (#26273)
…precated parameters `--enable-partitioning`, `--enable-session` and `--duplicate-detection` (#26478) * UPdtes * style fixed
* update azure-cli version to 2.49.0 * Apply suggestions from code review Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com> Co-authored-by: necusjz <necusjz@gmail.com> Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> * Update src/azure-cli/HISTORY.rst Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com> * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst * Update src/azure-cli/HISTORY.rst --------- Co-authored-by: Yishi Wang <yishiwang@microsoft.com> Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com> Co-authored-by: necusjz <necusjz@gmail.com> Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
* update * update * Update __init__.py * update
* update * Update config.yml
* bump version with sdk fix * revert back cli changes for sdk version 2016-10-01 breaking changes * try fix with 10.2.2
…onitoring` for service principle (#26528)
* recorded elastic pool tests * record elastic pool test for VBS enclave * add example * fix line too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.