-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Container] az container create
: Add new parameters for container security context for confidential ContainerGroupSku
#26273
[Container] az container create
: Add new parameters for container security context for confidential ContainerGroupSku
#26273
Conversation
️✔️AzureCLI-FullTest
|
Container |
I tried recording the test test_tag_update_by patch under command_modules/resource by running I looked at the context and found that a dummy context is being passed to the method, which has SubscriptionId=None. |
az container create
: Add new parameters for container security context for confidential ContainerGroupSkuaz container create
: Add new parameters for container security context for confidential ContainerGroupSku
@fnuarnav Could you please fix these CI issues? |
@fnuarnav Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 07-04) |
I found that the issue with recording tests was caused by PR #25689 class TagScenarioTest(ScenarioTest):
def __init__(self, *arg, **kwargs):
super().__init__(*arg, random_config_dir=True, **kwargs) The Could we consider making the |
@zhoxing-ms, how did you work around the |
@jiasli Yes, since it is not related to the business logic we are testing, so I removed it temporarily in my local environment to quickly unblock our recording |
…ecurity context for confidential ContainerGroupSku (Azure#26273)
Related command
az container create
Description
This PR:
upgrades azure-mgmt-containerinstance to 10.1.0
Adds Container security context properties for confidential ContainerGroupSku:
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.