{Eventhubs} `az eventhubs namespace/eventhub authorization-rule`: Migrate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ #25118

schaudhari6254888 · 2023-01-13T05:36:48Z

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

yonzhan · 2023-01-13T05:42:51Z

Eventhub

…into Auth_Eventhub

schaudhari6254888 · 2023-02-17T06:46:31Z

The CI's are failing due to the below test failed.
src/azure-cli/azure/cli/command_modules/iot/tests/hybrid_2019_03_01/test_iot_commands.py::test_iot_hub
We required to run this test because in this test Eventhubs Namespace commands are used.
Also this test is running successfully in my Local. I am using python version 3.8.
Can someone let me know What is going wrong here

schaudhari6254888 · 2023-02-20T06:32:31Z

This issue is still open. can someone please help me with this.

evelyn-ys · 2023-02-20T07:08:56Z

To rerun test for hybrid profile, you need to switch env using az cloud set --name $cloudName --profile $targetProfile first @schaudhari6254888

azure-client-tools-bot-prd · 2023-03-30T09:11:52Z

️✔️acr

️✔️acs

️✔️advisor

️✔️ams

️✔️apim

️✔️appconfig

️✔️appservice

️✔️aro

️✔️backup

️✔️batch

️✔️batchai

️✔️billing

️✔️botservice

️✔️cdn

️✔️cloud

️✔️cognitiveservices

️✔️config

️✔️configure

️✔️consumption

️✔️container

️✔️core

️✔️cosmosdb

️✔️databoxedge

️✔️dla

️✔️dls

️✔️dms

️✔️eventgrid

️✔️eventhubs

️✔️feedback

️✔️find

️✔️hdinsight

️✔️identity

️✔️iot

️✔️keyvault

️✔️kusto

️✔️lab

️✔️managedservices

️✔️maps

️✔️marketplaceordering

️✔️monitor

️✔️netappfiles

️✔️network

️✔️policyinsights

️✔️privatedns

️✔️profile

️✔️rdbms

️✔️redis

️✔️relay

️✔️resource

️✔️role

️✔️search

️✔️security

️✔️servicebus

️✔️serviceconnector

️✔️servicefabric

️✔️signalr

️✔️sql

️✔️sqlvm

️✔️storage

️✔️synapse

️✔️telemetry

️✔️util

️✔️vm

kairu-ms · 2023-04-04T07:55:17Z

src/azure-cli/azure/cli/command_modules/iot/tests/hybrid_2019_03_01/test_iot_commands.py

-        self.cmd('iot hub show-connection-string -n {0} --policy-name {1}'.format(hub, policy_name), checks=[
-            self.check_pattern('connectionString', policy_name_conn_str_pattern)
-        ])
+        self.cmd('iot hub show-connection-string -n {0} --policy-name {1}'.format(hub, policy_name))


Why you change the test_iot_commands.py file?

If you want to record the test_iot_hub test for profile 2019-03-01, please checkout to that profile first az cloud set --name AzureCloud --profile 2019-03-01-hybrid and run test in live again.

Why you want to re-record this test? Is this test related with eventhub module?

It uses eventhub cmdlet, we are not sure why it is asking for a recording. But, the testcase is buggy from iot hub side and we cannot get it to succeed.

…azure-cli into Auth_Eventhub

evelyn-ys · 2023-04-04T09:00:41Z

src/azure-cli/azure/cli/command_modules/eventhubs/tests/latest/test_cluster_commands.py

        # Create Cluster
-        self.cmd('eventhubs cluster create --resource-group {rg} --name {clustername} --location {loc} --tags tag1=value1',
+        self.cmd('eventhubs cluster create --resource-group test-migration --name {clustername} --location eastus --tags tag1=value1',


Don't use fixed personal resource group in test

@evelyn-ys, we will need to do it for this test case because cluster is an expensive resource to create and recently our testscripts created too many clusters that were unmonitored and cost us a lot and hence we decided to use a resource group that we can clean up every day to avoid wastage of resources and money.

The resource group preparation will do auto clean after test finishing. I don't understand why there will be "too many clusters that were unmonitored". Won't these clusters being deleted during deleting resource group?

Because Cluster can be deleted only 4 hours after creation.

Then can you add comments to the test for others who might need to rerun tests after your change to know why and how to prepare for the test

I have added the comments in cluster test file.

Can this PR be merged if this comment appears good?

evelyn-ys · 2023-04-12T09:04:56Z

src/azure-cli/azure/cli/command_modules/eventhubs/tests/latest/test_eventhub_commands.py

@@ -107,7 +107,7 @@ def test_eh_namespace(self, resource_group):
        self.cmd('eventhubs namespace authorization-rule keys renew --resource-group {rg} --namespace-name {namespacename} --name {authoname} --key {secondary}')

        # Delete Authorization Rule
-        self.cmd('eventhubs namespace authorization-rule delete --resource-group {rg} --namespace-name {namespacename} --name {authoname}')
+        self.cmd('eventhubs namespace authorization-rule delete --resource-group {rg} --namespace-name {namespacename} --name {authoname} --yes')


If this command didn't require --yes for confirmation, then it's breaking change for automation customers because they need to add --yes for their script or else it will hang

@kairu-ms Is there a way to not add --yes confirmation when using aaz to generate delete command?

Yes we can remove the confirmation message, to remove --yes when using aaz to generate delete command

…rate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ (Azure#25118) * Eventhub-namespace,Eventhub AuthRule * CI's Fixes * More CI fixes * Updates * CI's fixes * CI fixes * ci agaaaaaaaaaaaaaaaaaaaaaain * CI's fixes again * CI's fixessssssssssssssssssssss * updates * updates * updates * Hybrid profile test_iot_command.py succeeded * Recording added * CI's fixes again * UPdates * UPdates * UPdates * Updates * updatess removed --yes confirmation

Eventhub-namespace,Eventhub AuthRule

d98cffb

schaudhari6254888 changed the title ~~Eventhub-namespace,Eventhub AuthRule~~ Eventhub-namespace Authrule,Eventhub AuthRule Jan 13, 2023

yonzhan requested review from evelyn-ys and calvinhzy January 13, 2023 05:43

yonzhan assigned evelyn-ys Jan 13, 2023

yonzhan added this to the Jan 2023 (2023-02-07) milestone Jan 13, 2023

schaudhari6254888 changed the title ~~Eventhub-namespace Authrule,Eventhub AuthRule~~ [Eventhubs] '#ffffff' 'az eventhubs eventhub authorization-rule' Jan 14, 2023

schaudhari6254888 changed the title ~~[Eventhubs] '#ffffff' 'az eventhubs eventhub authorization-rule'~~ [Eventhubs] '#ffffff az eventhubs eventhub authorization-rule' Jan 14, 2023

schaudhari6254888 changed the title ~~[Eventhubs] '#ffffff az eventhubs eventhub authorization-rule'~~ [Eventhubs] 'az eventhubs eventhub authorization-rule' & 'az eventhubs namespace authorization-rule' : Migrating EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to aaz Jan 14, 2023

CI's Fixes

b2c0988

More CI fixes

e5240cb

evelyn-ys modified the milestones: Jan 2023 (2023-02-07), Feb 2023 (2023-03-07) Feb 2, 2023

schaudhari6254888 added 2 commits February 6, 2023 11:13

Merge branch 'dev' of https://github.com/schaudhari6254888/azure-cli …

1dc8c55

…into Auth_Eventhub

Updates

96aabad

schaudhari6254888 added 5 commits February 8, 2023 12:22

CI's fixes

3c98b4b

CI fixes

6d75593

ci agaaaaaaaaaaaaaaaaaaaaaain

abe2a55

CI's fixes again

37fb0a5

CI's fixessssssssssssssssssssss

02aa53c

schaudhari6254888 marked this pull request as ready for review February 20, 2023 06:23

schaudhari6254888 requested review from digimaun, zhoxing-ms and yanzhudd as code owners February 20, 2023 06:23

updates

36a904a

yonzhan modified the milestones: March 2023 (2023-04-04), April 2023 (2023-04-25) Mar 31, 2023

schaudhari6254888 and others added 2 commits April 4, 2023 11:17

updates

bb5d41c

Merge branch 'dev' into Auth_Eventhub

4ac3e2a

kairu-ms reviewed Apr 4, 2023

View reviewed changes

schaudhari6254888 added 2 commits April 4, 2023 13:51

Conflict resolved

58ae0e2

Merge branch 'Auth_Eventhub' of https://github.com/schaudhari6254888/…

321ea93

…azure-cli into Auth_Eventhub

evelyn-ys reviewed Apr 4, 2023

View reviewed changes

schaudhari6254888 added 2 commits April 5, 2023 12:54

Hybrid profile test_iot_command.py succeeded

14db74e

Recording added

fc50aec

CI's fixes again

9a7e1a4

schaudhari6254888 marked this pull request as ready for review April 5, 2023 12:20

schaudhari6254888 added 5 commits April 7, 2023 05:50

Conflict resolved

1cce941

UPdates

071f197

UPdates

ca2d597

UPdates

af1fa9d

Updates

452c548

evelyn-ys reviewed Apr 12, 2023

View reviewed changes

schaudhari6254888 added 2 commits April 12, 2023 16:12

updatess removed --yes confirmation

fb1ddd6

updatess

49ac367

evelyn-ys approved these changes Apr 13, 2023

View reviewed changes

yanzhudd approved these changes Apr 13, 2023

View reviewed changes

evelyn-ys merged commit 6d3f598 into Azure:dev Apr 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

{Eventhubs} `az eventhubs namespace/eventhub authorization-rule`: Migrate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ #25118

{Eventhubs} `az eventhubs namespace/eventhub authorization-rule`: Migrate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ #25118

schaudhari6254888 commented Jan 13, 2023

yonzhan commented Jan 13, 2023

schaudhari6254888 commented Feb 17, 2023

schaudhari6254888 commented Feb 20, 2023

evelyn-ys commented Feb 20, 2023

azure-client-tools-bot-prd bot commented Mar 30, 2023 •

edited

Loading

kairu-ms Apr 4, 2023

kairu-ms Apr 4, 2023

evelyn-ys Apr 4, 2023

damodaravadhani Apr 4, 2023

evelyn-ys Apr 4, 2023

damodaravadhani Apr 4, 2023

evelyn-ys Apr 6, 2023

schaudhari6254888 Apr 6, 2023

evelyn-ys Apr 7, 2023

schaudhari6254888 Apr 7, 2023

schaudhari6254888 Apr 11, 2023

evelyn-ys Apr 12, 2023

evelyn-ys Apr 12, 2023

schaudhari6254888 Apr 12, 2023

{Eventhubs} az eventhubs namespace/eventhub authorization-rule: Migrate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ #25118

{Eventhubs} az eventhubs namespace/eventhub authorization-rule: Migrate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ #25118

Conversation

schaudhari6254888 commented Jan 13, 2023

yonzhan commented Jan 13, 2023

schaudhari6254888 commented Feb 17, 2023

schaudhari6254888 commented Feb 20, 2023

evelyn-ys commented Feb 20, 2023

azure-client-tools-bot-prd bot commented Mar 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

{Eventhubs} `az eventhubs namespace/eventhub authorization-rule`: Migrate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ #25118

{Eventhubs} `az eventhubs namespace/eventhub authorization-rule`: Migrate EventHub entity AuthRule and EventHub Namespace AuthRule cmdlets to AAZ #25118

azure-client-tools-bot-prd bot commented Mar 30, 2023 •

edited

Loading