{EventHub} az eventhubs eventhub create/delete/update/show/list: Migrating Eventhub Entity cmdlets to AAZ
#26168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the May 2023 (2023-05-23) - For Build (Breaking change release) milestone
|
Hi @schaudhari6254888, |
|
EventHub |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 26168 in repo Azure/azure-cli |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Please fix CI issues. |
|
Since this PR makes a major version upgrade, external module's tests that used eventhubs cmdlets failed. I was able to run 5 of them successfully. However, the 4 shown below are buggy and fail on a non-eventhub cmdlet in their tests. I upgraded the EventHub api versions manually in the test recordings, but the CI's still complain. @kairu-ms , any suggestions would be appreciated. 
|
kairu-ms
reviewed
May 11, 2023
...i/azure/cli/command_modules/sql/tests/latest/recordings/test_sql_server_ms_support_mgmt.yaml
Outdated
Show resolved
Hide resolved
kairu-ms
reviewed
May 11, 2023
schaudhari6254888
requested review from
jsntcy,
evelyn-ys,
calvinhzy,
necusjz,
digimaun,
zhoxing-ms and
yanzhudd
as code owners
This reverts commit db1bc1f.
kairu-ms
approved these changes
May 17, 2023
zhoxing-ms
approved these changes
May 17, 2023
zhoxing-ms
approved these changes
May 17, 2023
evelyn-ys
approved these changes
May 17, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…grating Eventhub Entity cmdlets to AAZ (Azure#26168) * UPdates * UPdates * External service recordings * external test failures * Update custom.py * downgrading api version for python sdk * recordings * recordings * iot hub recording * pipeline fix * fix * fix * Updates * fixes * Updates * UPdates * Revert "UPdates" This reverts commit db1bc1f. * UPdates * CI's Againnnnnnnnnn * fixing cli style error --------- Co-authored-by: unknown <davadhani@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
This PR Adds the
Retention-Descriptionfeature for EventHub Entity. Which includecleanup-policy,retention-time-in-hours,tombstone-retention-time-in-hoursparameters. Also Deprecated themessage-retentionparameter , it is replaced withretention-time-in-hoursTesting Guide
History Notes
[EventHub] BREAKING CHANGE:
az eventhubs eventhub create/update: Remove--message-retentionparameter, it is replaced by--retention-time-in-hours[EventHub]
az eventhubs eventhub create/update: Add--cleanup-policy,--retention-time-in-hoursand--tombstone-retention-time-in-hoursto supportRetention-DescriptionfeatureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.