Add support for nanopi boards supported by periph.io #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
penguinland
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
LGTM!
As a heads-up: although SPI, I2C, and basic I/O work, digital interrupts will not work via Periph (and therefore most encoders won't work, nor will the ultrasonic sensor). Hardware PWM also won't work, though software PWM should (which is fine at low frequencies, but becomes garbage if you get over 200 Hz).
randhid
reviewed
Apr 4, 2023
randhid
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
LGTM, one little nit agree with @penguinland Hardware PWM won't work, but if it's not blocking for BeeRing this is fine for now.
viambot
added
safe to test
viambot
added
safe to test
penguinland
added a commit
that referenced
this pull request
Apr 6, 2023
…#2171) No changes to behavior should yet exist, as only a single board uses non-Periph pins so far. The changes to behavior will come when other boards start using non-Periph pins, which should allow them to use hardware PWM. Changes include: - Create the helper function `readIntFile` when initializing a board, and using that in several places instead of copying and pasting paragraphs of code. - Rename `gpioChipInfo` to `gpioChipsInfo` because it contains data about multiple chips. This helps with other variable names later, when we need to specify whether we're talking about the `gpio` or `pwm` chip. - Move the place where we look for hardware PWM chips, from where we initialize PWM structs to where we initialize the board's pin descriptions (the same place where we look for GPIO chips). - Search for PWM devices in several different directories. The new directories added in are their locations on the BeagleBone and Up4000 boards, though neither of those are used yet because the BB still uses Periph for its pins and the Up4000 isn't ready to go yet. This is just preparation! - Change the semantic meaning of the `PWMSysFsDir` field within the `GPIOBoardMapping` struct. It used to be a relative path within the one place we look for things, and it's now an absolute path because there are multiple places in sysfs that this directory might be, depending on which board you're on. Future changes that are planned but will be in a separate PR: - If you're unable to find a PWM device that you expect to find, _log the error but continue on._ Perhaps you're on a BeagleBone, which requires [modifying the device tree overlays from their factory defaults and then rebooting](https://forum.beagleboard.org/t/overlays-beaglebone-ai-64-pwm/32508), before you can see the PWM devices, and the rest of the board should still be usable as long as you don't try using hardware PWMs. - Change the BeagleBone board to stop using Periph and start using our own implementation of GPIO pins, including support for hardware PWM. - When the Up4000 board is further along, change it from Periph to this implementation, too. - Same thing with the [nanopi board](#2157), though that's lower priority for now. Tried on the Orin: everything still works normally. Tried on the BeagleBone: still needs work (hence why the future changes are not in this PR. They'll come later).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bee ring is using the nanopi neo air, which is now supported OOTB by periph.io periph/host#30
This means very little is required to use the nanopi neo air with RDK's genericlinux.
Tested this on the real hardware and confirmed that GPIO, i2c, and SPI are all working.