Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allwinner: Implement nanopi neo air #30

Merged
merged 8 commits into from
Mar 31, 2023

Conversation

biotinker
Copy link
Contributor

This builds off of #23 to expand support to also include the nanoPi Neo Air board. It also updates the Allwinner H3 pin mapping to properly support the PL pins, something that was missing in the #23 PR.

@google-cla
Copy link

google-cla bot commented Mar 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-cla
Copy link

google-cla bot commented Mar 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #30 (067bd1f) into main (339d73c) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main     #30   +/-   ##
=====================================
  Coverage   34.3%   34.3%           
=====================================
  Files         51      51           
  Lines       7992    7992           
=====================================
  Hits        2744    2744           
  Misses      5117    5117           
  Partials     131     131           
Impacted Files Coverage Δ
cpu/cpu.go 94.9% <100.0%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maruel
Copy link
Member

maruel commented Mar 18, 2023

Ran go mod tidy and pushed. Please pull and rebase and fix CI checks.

@biotinker
Copy link
Contributor Author

CI checks should now all be passing

@maruel
Copy link
Member

maruel commented Mar 22, 2023

The go mod tidy failure is abnormal since I had fixed it. Will look later what the heck is happening. Sorry about that.

@biotinker
Copy link
Contributor Author

Extra weird is that the CI checks pass in my personal repo, but should presumably be using the exact same workflow as here...

https://github.com/biotinker/host/actions/runs/4491701924

@biotinker
Copy link
Contributor Author

Anything I can do to help get this through? Happy to look into the failure more given a starting point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants