Bump actions/checkout from 2.3.5 to 2.4.0 #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
approved these changes
Nov 16, 2021
Contributor
|
Failing due to #92 |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/github_actions/actions/checkout-2.4.0
branch
mmlb
added a commit
that referenced
this pull request
Nov 30, 2021
Dependabot based push/pr builds don't have access to the quay secrets it seems (github magic?) (see [1], [2]) so lets avoid it all together. Dependabot pushes/PRs can be recognized by the github.actor value according to the GitHub docs[3]. [1]: #89 [2]: #95 [3]: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/automating-dependabot-with-github-actions#handling-pull_request-events Signed-off-by: Manuel Mendez <mmendez@equinix.com>
mmlb
added a commit
that referenced
this pull request
Nov 30, 2021
Dependabot based push/pr builds don't have access to the quay secrets it seems (github magic?) (see [1], [2]) so lets avoid it all together. Dependabot pushes/PRs can be recognized by the github.actor value according to the GitHub docs[3]. Fixes #92 [1]: #89 [2]: #95 [3]: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/automating-dependabot-with-github-actions#handling-pull_request-events Signed-off-by: Manuel Mendez <mmendez@equinix.com>
mmlb
added a commit
that referenced
this pull request
Nov 30, 2021
Dependabot based push/pr builds don't have access to the quay secrets it seems (github magic?) (see [1], [2]) so lets avoid it all together. Dependabot pushes/PRs can be recognized by the github.actor value according to the GitHub docs[3]. Fixes #92 [1]: #89 [2]: #95 [3]: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/automating-dependabot-with-github-actions#handling-pull_request-events Signed-off-by: Manuel Mendez <mmendez@equinix.com>
mmlb
added a commit
that referenced
this pull request
Nov 30, 2021
Dependabot based push/pr builds don't have access to the quay secrets it seems (github magic?) (see [1], [2]) so lets avoid it all together. Dependabot pushes/PRs can be recognized by the github.actor value according to the GitHub docs[3]. Fixes #92 [1]: #89 [2]: #95 [3]: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/automating-dependabot-with-github-actions#handling-pull_request-events Signed-off-by: Manuel Mendez <mmendez@equinix.com>
mmlb
added a commit
that referenced
this pull request
Nov 30, 2021
Dependabot PRs are different than other non-contributor PRs in that the branch comes from this repo, which normally allows the secret to be available for CI yet the builds still fail (see [1], [2]). It seems that GitHub does not make secrets available for these PRs as yet another special case [3]. If we skip logging in to quay for dependabot then we side step this all together. Dependabot pushes/PRs can be recognized by the github.actor value according to the GitHub docs [3]. [1]: #89 [2]: #95 [3]: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/automating-dependabot-with-github-actions#handling-pull_request-events Fixes #92 Signed-off-by: Manuel Mendez <mmendez@equinix.com>
mergify bot
added a commit
that referenced
this pull request
Nov 30, 2021
## Description Avoids logging into quay for dependabot builds. ## Why is this needed Fixes #92 Dependabot PRs are different than other non-contributor PRs in that the branch comes from this repo, which normally allows the secret to be available for CI yet the builds still fail (see [1], [2]). It seems that GitHub does not make secrets available for these PRs as yet another special case [3]. If we skip logging in to quay for dependabot then we side step this all together. Dependabot pushes/PRs can be recognized by the github.actor value according to the GitHub docs [3]. [1]: #89 [2]: #95 [3]: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/automating-dependabot-with-github-actions#handling-pull_request-events I wanted to avoid logging in for non main pushes all together but that may make kernel testing harder than strictly necessary. ## How Has This Been Tested? CI? ## How are existing users impacted? What migration steps/scripts do we need? Updated dependencies sooner hopefully.
Contributor
|
@dependabot reopen |
dependabot
bot
restored the
dependabot/github_actions/actions/checkout-2.4.0
branch
Contributor
|
@dependabot rebase |
Bumps [actions/checkout](https://github.com/actions/checkout) from 2.3.5 to 2.4.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2.3.5...v2.4.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/github_actions/actions/checkout-2.4.0
branch
from
3a37332 to
625efb6
Compare
mergify
bot
deleted the
dependabot/github_actions/actions/checkout-2.4.0
branch
mmlb
added a commit
that referenced
this pull request
Nov 30, 2021
We skip logging in to quay.io when github.actor is dependabot in [#96] but did not check if any pushes were attempted. This was missed in the subsequent dependabot PRs [#89] and [#95] because there was no branch protection setup and I added the ready-to-merge label so mergify merged it :(. This should fix that. [#89]: #89 [#95]: #95 [#96]: #96 Signed-off-by: Manuel Mendez <mmendez@equinix.com>
mmlb
added a commit
that referenced
this pull request
Nov 30, 2021
We skipped logging in to quay.io when github.actor is dependabot in [#96] but did not check if any pushes were attempted. This was missed in the subsequent dependabot PRs [#89] and [#95] because there was no branch protection setup and I added the ready-to-merge label so mergify merged it :(. This should fix that. [#89]: #89 [#95]: #95 [#96]: #96 Signed-off-by: Manuel Mendez <mmendez@equinix.com>
mmlb
added a commit
that referenced
this pull request
Nov 30, 2021
We skipped logging in to quay.io when github.actor is dependabot in [#96] but did not check if any pushes were attempted. This change will avoid that failure. This was missed in the subsequent dependabot PRs [#89] and [#95] because there was no branch protection setup and I added the ready-to-merge label so mergify merged it :(. I've added branch protection to require the actions to pass. [#89]: #89 [#95]: #95 [#96]: #96 Signed-off-by: Manuel Mendez <mmendez@equinix.com>
mergify bot
added a commit
that referenced
this pull request
Nov 30, 2021
## Description Avoids pushing to quay if the PR/push originates from dependabot. ## Why is this needed We skipped logging in to quay.io when github.actor is dependabot in [#96] but did not check if any pushes were attempted. This change will avoid that failure. This was missed in the subsequent dependabot PRs [#89] and [#95] because there was no branch protection setup and I added the ready-to-merge label so mergify merged it :(. I've added branch protection to require the actions to pass. [#89]: #89 [#95]: #95 [#96]: #96 ## How Has This Been Tested? CI
jacobweinstock
added a commit
that referenced
this pull request
Aug 31, 2022
Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you. Requirements: - [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md) - [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security) - [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev) - [X] I am actively contributing to 1 or more Tinkerbell subprojects - [X] Reviewer for at least 1 month - [X] Shallow understanding of the technical goals and direction of the repository - [X] Shallow understanding of the technical domain of the repository - [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features PR Reviews #98 #89 #130 PR merges #118 #117 #116 #115 #59 Sponsor Request from @mmlb @thebsdbox
8 tasks
mergify bot
added a commit
that referenced
this pull request
Aug 31, 2022
Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you. Requirements: - [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md) - [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security) - [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev) - [X] I am actively contributing to 1 or more Tinkerbell subprojects - [X] Reviewer for at least 1 month - [X] Shallow understanding of the technical goals and direction of the repository - [X] Shallow understanding of the technical domain of the repository - [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features PR Reviews #98 #89 #130 PR merges #118 #117 #116 #115 #59 Sponsor Request from @mmlb @thebsdbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps actions/checkout from 2.3.5 to 2.4.0.
Release notes
Sourced from actions/checkout's releases.
Commits
ec3a7ceset insteadOf url for org-id (#621)fd47087codeql should analyze lib not dist (#620)3d677acscript to generate license info (#614)826ba42npm audit fix (#612)eb8a193update dev dependencies and react to new linting rules (#611)c49af7cCreate codeql-analysis.yml (#602)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)