Update dhcpcd onboot and service containers: #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network interfaces were not coming up. Logs showed "main: pidfile_lock: Permission denied". Adding the bind mounts and directory creation resolved the issue. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
thebsdbox
approved these changes
Apr 23, 2022
Contributor
thebsdbox
left a comment
thebsdbox
left a comment
There was a problem hiding this comment.
Someone fiddled with the bind mounts a while ago. This seems sane to me.
jacobweinstock
added a commit
that referenced
this pull request
Aug 31, 2022
Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you. Requirements: - [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md) - [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security) - [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev) - [X] I am actively contributing to 1 or more Tinkerbell subprojects - [X] Reviewer for at least 1 month - [X] Shallow understanding of the technical goals and direction of the repository - [X] Shallow understanding of the technical domain of the repository - [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features PR Reviews #98 #89 #130 PR merges #118 #117 #116 #115 #59 Sponsor Request from @mmlb @thebsdbox
8 tasks
mergify bot
added a commit
that referenced
this pull request
Aug 31, 2022
Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you. Requirements: - [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md) - [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security) - [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev) - [X] I am actively contributing to 1 or more Tinkerbell subprojects - [X] Reviewer for at least 1 month - [X] Shallow understanding of the technical goals and direction of the repository - [X] Shallow understanding of the technical domain of the repository - [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features PR Reviews #98 #89 #130 PR merges #118 #117 #116 #115 #59 Sponsor Request from @mmlb @thebsdbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was experiencing the same issue as here, but removing all the bind mounts didn't resolve it for me. However, adding the bind mounts back and creating the
/var/lib/dhcpcddirectory was the only way for me to get the interfaces to start working. With these changes the dhcpcd.log files were error free.Hey @thebsdbox. If you have any cycles, I'd be very interested to know if the
main: pidfile_lock: Permission deniederror still happens for you with this PR.Update dhcpcd onboot and service containers:
Network interfaces were not coming up. Logs showed "
main: pidfile_lock: Permission denied". Adding the bind mounts and directory creation resolved the issue.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: