Skip to content

Conversation

@jacobweinstock
Copy link
Member

Description

Adds Apache 2.0 License

Why is this needed

Without it contributing is dodgy.

Fixes: #58

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this going to be filled out?

Copy link
Member Author

@jacobweinstock jacobweinstock Jun 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @micahhausler good question. does it need to be filled out? i don't understand this line very well. looking at other repos, some have it filled out and some don't.

not filled out:
https://github.com/kubernetes/kubernetes/blob/master/LICENSE

filled out:
https://github.com/kubernetes/minikube/blob/master/LICENSE

Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the date on the footer? @jacobweinstock

@jacobweinstock
Copy link
Member Author

jacobweinstock commented Jun 15, 2021

Can we fix the date on the footer? @jacobweinstock

hey @thebsdbox, do you mean something like add year but leave everything else? Copyright 2021 [name of copyright owner]?

@thebsdbox thebsdbox merged commit 0096fe9 into main Jun 18, 2021
@thebsdbox thebsdbox deleted the add-license-1 branch June 18, 2021 14:23
jacobweinstock added a commit that referenced this pull request Aug 31, 2022
Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you.

Requirements:

- [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md)
- [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security)
- [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev)
- [X] I am actively contributing to 1 or more Tinkerbell subprojects
- [X] Reviewer for at least 1 month
- [X] Shallow understanding of the technical goals and direction of the repository
- [X] Shallow understanding of the technical domain of the repository
- [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features

PR Reviews
#98
#89
#130

PR merges
#118
#117
#116
#115
#59

Sponsor Request from
@mmlb 
@thebsdbox
@jacobweinstock jacobweinstock mentioned this pull request Aug 31, 2022
8 tasks
mergify bot added a commit that referenced this pull request Aug 31, 2022
Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you.

Requirements:

- [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md)
- [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security)
- [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev)
- [X] I am actively contributing to 1 or more Tinkerbell subprojects
- [X] Reviewer for at least 1 month
- [X] Shallow understanding of the technical goals and direction of the repository
- [X] Shallow understanding of the technical domain of the repository
- [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features

PR Reviews
#98
#89
#130

PR merges
#118
#117
#116
#115
#59

Sponsor Request from
@mmlb 
@thebsdbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a License file

5 participants