Skip to content

Conversation

@mmlb
Copy link
Contributor

@mmlb mmlb commented Nov 30, 2021

Description

Avoids pushing to quay if the PR/push originates from dependabot.

Why is this needed

We skipped logging in to quay.io when github.actor is dependabot in #96 but
did not check if any pushes were attempted. This change will avoid that
failure.

This was missed in the subsequent dependabot PRs #89 and #95 because there
was no branch protection setup and I added the ready-to-merge label so mergify
merged it :(. I've added branch protection to require the actions to pass.

How Has This Been Tested?

CI

We skipped logging in to quay.io when github.actor is dependabot in [#96] but
did not check if any pushes were attempted. This change will avoid that
failure.

This was missed in the subsequent dependabot PRs [#89] and [#95] because there
was no branch protection setup and I added the ready-to-merge label so mergify
merged it :(. I've added branch protection to require the actions to pass.

[#89]: #89
[#95]: #95
[#96]: #96

Signed-off-by: Manuel Mendez <mmendez@equinix.com>
@mmlb mmlb requested a review from tstromberg November 30, 2021 20:58
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Nov 30, 2021
@mergify mergify bot merged commit 54bae38 into main Nov 30, 2021
@mergify mergify bot deleted the ci-push-only-if-not-dependabot branch November 30, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Signal to Mergify to merge the PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants