Skip to content

Commit ca1560f

Browse files
authored
Don't try to login to quay if a push is made by dependabot (#96)
## Description Avoids logging into quay for dependabot builds. ## Why is this needed Fixes #92 Dependabot PRs are different than other non-contributor PRs in that the branch comes from this repo, which normally allows the secret to be available for CI yet the builds still fail (see [1], [2]). It seems that GitHub does not make secrets available for these PRs as yet another special case [3]. If we skip logging in to quay for dependabot then we side step this all together. Dependabot pushes/PRs can be recognized by the github.actor value according to the GitHub docs [3]. [1]: #89 [2]: #95 [3]: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/automating-dependabot-with-github-actions#handling-pull_request-events I wanted to avoid logging in for non main pushes all together but that may make kernel testing harder than strictly necessary. ## How Has This Been Tested? CI? ## How are existing users impacted? What migration steps/scripts do we need? Updated dependencies sooner hopefully.
2 parents 8752d18 + c1f2037 commit ca1560f

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

.github/workflows/kernel-push.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ jobs:
1212
uses: actions/checkout@v2.3.5
1313

1414
- name: Login to quay.io
15+
if: ${{ github.actor != 'dependabot[bot]' }}
1516
uses: docker/login-action@v1
1617
with:
1718
registry: quay.io

.github/workflows/push.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ jobs:
1818
uses: docker/setup-buildx-action@v1.3.0
1919

2020
- name: Login to quay.io
21+
if: ${{ github.actor != 'dependabot[bot]' }}
2122
uses: docker/login-action@v1
2223
with:
2324
registry: quay.io

0 commit comments

Comments
 (0)