Merged
Conversation
13 tasks
minkimcello
force-pushed
the
mk/preview-plus
branch
from
f33a910 to
5bfc8de
Compare
minkimcello
force-pushed
the
mk/update-readmes
branch
from
b9eeeb1 to
3996fbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We've been delaying finalizing the
v2release because we wanted to include tests but unfortunately it looks like we'll need to wrap this up for now and add tests (with proper mocking of package registry and octokit) at a later date.Every action in
v2has been refactored to be very similar tov1(in the way it's used in the workflow) so as long as you follow the readmes when upgrading fromv1tov2, you should be fine.Here are all the pull requests that were involved in refactoring the bash actions to node:
publish-pr-previewsynchronize-npm-tagssynchronize-with-npmThese readme links won't be up to date until after this PR is merged
This PR will resolve #68 🥹
Approach
synchronize-npm-tagsandpreviewworkflows that I was using to manually test the actionsyarnaction. This action was originally created to fail a workflow if there were any warnings but it's redundant now as this can be done by modifying our effection exec (for yarn install) fromjointoexpect