Conversation
89af8ba to
750b213
Compare
bc4e68e to
fcebdbc
Compare
ac6805e to
2fbee67
Compare
497bebb to
cc69151
Compare
cc69151 to
292c24f
Compare
292c24f to
3b51f33
Compare
08f6db7 to
7320ba9
Compare
2afd33f to
8728263
Compare
a6799ce to
c427b05
Compare
4fac799 to
74aad74
Compare
50127d7 to
e54b243
Compare
e54b243 to
fd7049f
Compare
cowboyd
left a comment
There was a problem hiding this comment.
Is this almost ready to go? Curious. How do we handle the publishing based on the presence of a preview label?
I just need to add some informative console logs here and there and it will be good to go. In terms of publishing from an existing prerelease, we originally planned for something along the lines of
|
5a431de to
02cdcac
Compare
169e735 to
070bf5f
Compare
070bf5f to
d513607
Compare
Oh I forgot to answer your question. This can be done from the workflow. I could've incorporated it into the action but using the workflow prevents having to build the action so we'll save time. |
Motivation
To finally rewrite the
publish-pr-previewaction in typescript.Approach
What's New?
IGNOREandNPM_PUBLISHoptionsIGNOREwas originally for us to prevent publishing our gatsby/docusaurus website directories but we have them marked asprivatepackages and the action will skip overprivatepackages anywayNPM_PUBLISHwas to give developers the option to useyarn publishbut I think we're just usingnpm publishso it's not necessary for us to have this option... I think.npmrcfiles. We're lettingactions/setup-nodetake care of all of thatBEFORE_ALLwithINSTALL_SCRIPTyarn installand thenBEFORE_ALLbefore proceeding on to publishing but now we just combined the two so it's either justyarn installoruser-specified install script. This just means users need to configureINSTALL_SCRIPT: yarn install && yarn other stuffif they need to run additional steps_with__and/with_but I found out underscore is not valid for semver prerelease identifiers so we're now replacing both_and/with-instead1.0.0=>1.0.0-abcdefgh(SHA)1.0.0=>1.0.1-branch.0(branch name as prerelease identifier with increments)1.0.0but if1.2.3was released and I haven't had a chance to rebase yet, the action will publish1.2.4-branch.0.yarn addif there'syarn.lockin project,npm installby defaultPublishing Tested
1.15.0published1.15.1-mk-preview-js.01.15.1-mk-preview-js.1npm view tagto detect that.0was already published so it incremented up to.11.16.0and ran action and it published1.16.1-mk-preview-js.0from1.15.0.0again because we never published a preview for1.16.1-x1.16.1-mk-preview-js.1and forcedincreaseFromas1.16.0to test multiple attempt functionality1.16.1-mk-preview-js.2after attempting to publish.0and.1.0,.1, and.2increaseFromof1.16.0and action published1.16.1-mk-preview-js.3TODOs
Once this PR is merged, we can use this action by calling it from the
mainbranch:But I would like to rewrite the other actions too so that we can officially release everything as
v2.