Merged
Conversation
Member
|
📣 NOTIFICATION Generated by @thefrontside/actions |
13 tasks
8737ce1 to
f48b44d
Compare
509610f to
323e09c
Compare
323e09c to
48c1f28
Compare
Contributor
Author
|
@cowboyd Is there a correct way to write tests for both the |
synchronize-with-npm in Nodesynchronize-with-npm in Node
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To rewrite the release action in typescript.
Approach
What's New?
IGNOREandNPM_PUBLISHarguments. Similar to what was done in #65. We're skipping packages marked as private and we're usingnpm publishfor all publishing (as opposed to giving the users the ability to provide their own publish command likeyarn publish)BEFORE_ALLwithINSTALL_SCRIPTold action: get all packages npm view each package to see which ones to publish yarn install yarn custom_script for each package npm publish pkg @ version git tag {pkg}-v{version} git push tag for each package.json with deprecate property npm deprecate pkg deprecate-descriptionnew action: separate packages into two lists packages to deprecate non-private packages npm view non-private packages to see if it should publish if there are any packages to publish yarn install || custom script for each package npm publish git tag pkg-v{version} if there are any packages to deprecate for each package npm deprecate pkg deprecate-descriptionTODOs
Write testssynchronize-npm-tagsin Node #66 first and switch base branch of this PR tomain.