Merged
Conversation
Member
|
📣 NOTIFICATION Generated by @thefrontside/actions |
13 tasks
3 tasks
synchronize-npm-tags in Nodesynchronize-npm-tags in Node
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current
synchronize-npm-tagsaction does not support monorepos yet, and we have a lot of stale NPM tags onbigtestandeffection:Approach
What's New?
npm dist-tag lsfrom the root so it worked fine for a normal repository but wouldn't work for a monorepo. The new action looks something like this:PRESERVEargument for users to specify tags they want to keep even if there are no corresponding branchesbeta,alpha,dev, andlatest. These are included regardless of if users specify their own tags._with__and then replacing/with_. The new preview action replaces both_and/with a-. This newsynchronize-npm-tagsaction will take the list of branches and convert them into both formats in order to determine if it should be removed or not to ensure that active NPM tags will be preserved regardless of if they were generated by the old or new preview action.Other Stuff
@frontside/actions-utils.TODOs
Should I include any other default protected tags to the list?Add tests