Track failed publish attempts for preview action#70
Merged
minkimcello merged 7 commits intov2from Apr 29, 2022
Merged
Conversation
Member
|
📣 NOTIFICATION Generated by @thefrontside/actions |
minkimcello
force-pushed
the
mk/preview-plus
branch
from
2cad55f to
f33a910
Compare
This was referenced Apr 29, 2022
Merged
minkimcello
changed the title
minkimcello
force-pushed
the
mk/preview-plus
branch
from
f33a910 to
5bfc8de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview action attempts to publish preview packages three times.
This is all after it passes a long list of prerequisites and conditions. But the reason we attempt three times is in anticipation of any delays of npm updating its registry (in case someone pushes multiple commits in a short time span and publishing happens too quickly back to back).
Although unlikely, we should still keep track of packages that failed to publish even after the three attempts and include it in the github comment.